summaryrefslogtreecommitdiff
path: root/starmath
diff options
context:
space:
mode:
authorTor Lillqvist <tml@collabora.com>2014-12-12 17:57:19 +0200
committerTor Lillqvist <tml@collabora.com>2014-12-12 18:06:39 +0200
commitcbf0c9f8332be9abfed6016f9708e3260331eb2d (patch)
tree271ecc5acc027eda63519168166816bb65e10661 /starmath
parentd79b96cf6564187c96f5a1451ca98e2c93adee77 (diff)
Tentative fix for fdo#83937
One clear bug in the code, in my opinion, was that PDFSigningPKCS7PasswordCallback() returned its argument as such. However, a PK11PasswordFunc should return "a pointer to the password. This memory must have been allocated with PR_Malloc or PL_strdup", says https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/SSL_functions/pkfnc.html . I could not test this fix fully before my hardware token decided to block itself, thanks to too many wrong PIN attempts. Possibly it would work to even just pass NULL for the password callback function and its argument to NSS_CMSEncoder_Start(). After all, at least with the hardware token and associated software that I tested with, the software itself pops up a dialog asking for the PIN (password). Change-Id: I85a8b2833cfdd1a1d7b7779016fefb71dd53ab80
Diffstat (limited to 'starmath')
0 files changed, 0 insertions, 0 deletions