diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2019-11-12 21:53:31 +0100 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2019-11-13 15:06:42 +0100 |
| commit | 913d34ec6b8fdb2796f76ce90fee51ade2051189 (patch) | |
| tree | 261aefa505e7d71ad38c9d5b2ae0cfe92e9738c8 /solenv | |
| parent | eea0879cdf1b40e6ce424dd97b58e2a84846ad79 (diff) | |
Extend loplugin:salbool to loplugin:fakebool
...checking for unnecessary uses of more "fake bool" types.
In the past, some of the checks involving the types of variables or data
members, or the return types of functions, issued warnings that required
surrounding code to be changed too (e.g., when changing the signature of a
function whose address was taken). These checks have been tightened now to not
warn in such cases (which avoids warnings that require changes to additional
code, or changes that might even be impossible to make, at the cost of being
less aggressive about removing all unnecessary uses of those "fake bool" types).
Change-Id: I70eb75039817cda34ed611387ee27dc5f36a3e2e
Reviewed-on: https://gerrit.libreoffice.org/82554
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'solenv')
| -rw-r--r-- | solenv/CompilerTest_compilerplugins_clang.mk | 2 | ||||
| -rw-r--r-- | solenv/clang-format/blacklist | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/solenv/CompilerTest_compilerplugins_clang.mk b/solenv/CompilerTest_compilerplugins_clang.mk index 1014d3f8c909..6766e3821bf2 100644 --- a/solenv/CompilerTest_compilerplugins_clang.mk +++ b/solenv/CompilerTest_compilerplugins_clang.mk @@ -36,6 +36,7 @@ $(eval $(call gb_CompilerTest_add_exception_objects,compilerplugins_clang, \ compilerplugins/clang/test/expressionalwayszero \ compilerplugins/clang/test/intvsfloat \ compilerplugins/clang/test/faileddyncast \ + compilerplugins/clang/test/fakebool \ compilerplugins/clang/test/finalprotected \ compilerplugins/clang/test/flatten \ compilerplugins/clang/test/fragiledestructor \ @@ -60,7 +61,6 @@ $(eval $(call gb_CompilerTest_add_exception_objects,compilerplugins_clang, \ compilerplugins/clang/test/refcounting \ compilerplugins/clang/test/referencecasting \ compilerplugins/clang/test/returnconstval \ - compilerplugins/clang/test/salbool \ compilerplugins/clang/test/salcall \ compilerplugins/clang/test/sallogareas \ compilerplugins/clang/test/salunicodeliteral \ diff --git a/solenv/clang-format/blacklist b/solenv/clang-format/blacklist index 9f390fc07640..6f092e83d27b 100644 --- a/solenv/clang-format/blacklist +++ b/solenv/clang-format/blacklist @@ -1679,6 +1679,7 @@ compilerplugins/clang/expressionalwayszero.cxx compilerplugins/clang/externandnotdefined.cxx compilerplugins/clang/externvar.cxx compilerplugins/clang/faileddyncast.cxx +compilerplugins/clang/fakebool.cxx compilerplugins/clang/finalclasses.cxx compilerplugins/clang/finalprotected.cxx compilerplugins/clang/flatten.cxx @@ -1714,7 +1715,6 @@ compilerplugins/clang/redundantpointerops.cxx compilerplugins/clang/refcounting.cxx compilerplugins/clang/rendercontext.cxx compilerplugins/clang/reservedid.cxx -compilerplugins/clang/salbool.cxx compilerplugins/clang/sallogareas.cxx compilerplugins/clang/salunicodeliteral.cxx compilerplugins/clang/sfxpoolitem.cxx @@ -1787,6 +1787,7 @@ compilerplugins/clang/test/expressionalwayszero.cxx compilerplugins/clang/test/externvar.cxx compilerplugins/clang/test/externvar.hxx compilerplugins/clang/test/faileddyncast.cxx +compilerplugins/clang/test/fakebool.cxx compilerplugins/clang/test/finalprotected.cxx compilerplugins/clang/test/flatten.cxx compilerplugins/clang/test/indentation.cxx @@ -1803,7 +1804,6 @@ compilerplugins/clang/test/redundantinline.cxx compilerplugins/clang/test/redundantinline.hxx compilerplugins/clang/test/redundantpointerops.cxx compilerplugins/clang/test/refcounting.cxx -compilerplugins/clang/test/salbool.cxx compilerplugins/clang/test/salunicodeliteral.cxx compilerplugins/clang/test/salunicodeliteral.hxx compilerplugins/clang/test/stringconcatauto.cxx |