update loplugin stylepolice to check local pointers vars

are actually pointer vars.

Also convert from regex to normal code, so we can enable this
plugin all the time.

Reviewed-on: https://gerrit.libreoffice.org/24391
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
(cherry picked from commit e8fd5a07eca70912ddee45aaa34d434809b59fb7)

Change-Id: Ie36a25ecba61c18f99c77c77646d6459a443cbd1

2 files changed, 5 insertions, 5 deletions

diff --git a/slideshow/source/engine/shapes/drawshapesubsetting.cxx b/slideshow/source/engine/shapes/drawshapesubsetting.cxx
index 183eaadf89a8..3a62136209e4 100644
--- a/slideshow/source/engine/shapes/drawshapesubsetting.cxx
+++ b/slideshow/source/engine/shapes/drawshapesubsetting.cxx
@@ -398,8 +398,8 @@ namespace slideshow
             // the whole shape set
 
             // determine new subset range
-            for( const auto& pShape : maSubsetShapes )
-                updateSubsetBounds( pShape );
+            for( const auto& rSubsetShape : maSubsetShapes )
+                updateSubsetBounds( rSubsetShape );
 
             updateSubsets();
 
diff --git a/slideshow/source/engine/transitions/slidechangebase.cxx b/slideshow/source/engine/transitions/slidechangebase.cxx
index 07ca4eb8b20b..a1209371efc4 100644
--- a/slideshow/source/engine/transitions/slidechangebase.cxx
+++ b/slideshow/source/engine/transitions/slidechangebase.cxx
@@ -446,12 +446,12 @@ void SlideChangeBase::viewsChanged()
     if( mbFinished )
         return;
 
-    for( auto& pView : maViewData )
+    for( auto& rView : maViewData )
     {
         // clear stale info (both bitmaps and sprites prolly need a
         // resize)
-        clearViewEntry( pView );
-        addSprites( pView );
+        clearViewEntry( rView );
+        addSprites( rView );
     }
 }