sw_redlinehide: fix assert caused by buggy lcl_ModifyOfst

converting ooo67907-1.doc to ODT asserts in fillSoftPageBreakList()
while mapping an invalid (too large) GetOfst() of a follow frame.

There are some problems with the lcl_ModifyOfst() implementation and
usage:

1. the implementation iterates over all follows; but the follows will
   get the same SwClientNotify() call as the frame itself, so in effect
   the follows' Ofsts will be modified multiple times

2. the calls to lcl_ModifyOfst pass in a positive nLen whether the
   text is deleted or inserted; surely for deletions the Ofst should be
   subtracted from instead of added to

3. the special-casing of RES_DEL_CHR to COMPLETE_STRING while
   RES_DEL_TXT uses the length does not appear to be justified

The assert happens since b15f1ed2a1df45a57b587ac90efa90c1c18866fc
but the lcl_ModifyOfst logic never made sense.

Change-Id: Ie92628515bbee0fcc2123eb412057d8c0fd0b2f1
Reviewed-on: https://gerrit.libreoffice.org/66679
Tested-by: Jenkins
Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>

0 files changed, 0 insertions, 0 deletions