boost::optional: replace uses of get_value_or with value_or

...in preparation for wholesale replacement of boost::optional with
o3tl::optional, which will be an alias for either std::optional or
boost::optional, and std::optional only has value_or.

boost::optional::value_or was added with <https://github.com/boostorg/optional/
commit/3984c9f9a157ef116cea69bc8bb20f433320eb61> "Added function value_or()",
which according to git-describe first appeared in tag boost-1.56.0.  We appear
to have no strict Boost baseline (the closest we get is with

> [AC_MSG_ERROR(boost/spirit/include/classic_core.hpp not found. install boost >= 1.36)]

in configure.ac), and at least CentOS 7 TDF machine tb76 only has
boost-devel-1.53.0-27.el7.x86_64.  However, any environment using Xcode < 10
that needs to make o3tl::optional fall back to boost::optional should use
--without-system-boost, and external/boost is currently at 1.69.0, so should be
safe.

ATTENTION:  In isolation, this commit will break in any environment that uses
Boost older than 1.56.0.  It requires the following commit introducing
o3tl::optional.  (But doing these changes in individual commits was deemed more
valuable than supporting a hypothetical future git-bisect against an old Boost.)

Change-Id: Ib31affa3eebf0d0029d8620dc6abb7a60f6c7629
Reviewed-on: https://gerrit.libreoffice.org/84127
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>

1 files changed, 3 insertions, 3 deletions

diff --git a/sfx2/source/appl/appcfg.cxx b/sfx2/source/appl/appcfg.cxx
index 8b9ca9e6f413..44065b512989 100644
--- a/sfx2/source/appl/appcfg.cxx
+++ b/sfx2/source/appl/appcfg.cxx
@@ -350,7 +350,7 @@ void SfxApplication::GetOptions( SfxItemSet& rSet )
                             SfxUInt16Item(
                                 rPool.GetWhich(SID_INET_PROXY_TYPE),
                                 (officecfg::Inet::Settings::ooInetProxyType::
-                                 get().get_value_or(0)))))
+                                 get().value_or(0)))))
                     {
                         bRet = true;
                     }
@@ -370,7 +370,7 @@ void SfxApplication::GetOptions( SfxItemSet& rSet )
                             SfxInt32Item(
                                 rPool.GetWhich(SID_INET_HTTP_PROXY_PORT),
                                 (officecfg::Inet::Settings::
-                                 ooInetHTTPProxyPort::get().get_value_or(0)))))
+                                 ooInetHTTPProxyPort::get().value_or(0)))))
                     {
                         bRet = true;
                     }
@@ -390,7 +390,7 @@ void SfxApplication::GetOptions( SfxItemSet& rSet )
                             SfxInt32Item(
                                 rPool.GetWhich(SID_INET_FTP_PROXY_PORT),
                                 (officecfg::Inet::Settings::ooInetFTPProxyPort::
-                                 get().get_value_or(0)))))
+                                 get().value_or(0)))))
                     {
                         bRet = true;
                     }