diff options
author | Noel Grandin <noelgrandin@gmail.com> | 2015-10-25 17:33:13 +0200 |
---|---|---|
committer | Noel Grandin <noelgrandin@gmail.com> | 2015-10-26 05:47:06 +0000 |
commit | e6dce260833ecddf0da9c85132665a7759fc1f17 (patch) | |
tree | 1deb554cc06bd028335f986303043a5cae757cd2 /sd/source/ui | |
parent | bebc20c62be2df2cf2741fb82945ce6b631d2fe5 (diff) |
cppcheck:noExplicitConstructor
Change-Id: I06f33af242c60e0349417ceab3ca4a6d47cd402d
Reviewed-on: https://gerrit.libreoffice.org/19589
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'sd/source/ui')
45 files changed, 62 insertions, 62 deletions
diff --git a/sd/source/ui/animations/CustomAnimationDialog.hxx b/sd/source/ui/animations/CustomAnimationDialog.hxx index 0f82354e9e9f..757153b5ebe0 100644 --- a/sd/source/ui/animations/CustomAnimationDialog.hxx +++ b/sd/source/ui/animations/CustomAnimationDialog.hxx @@ -97,7 +97,7 @@ const sal_Int32 nPropertyTypeScale = 21; class PropertySubControl { public: - PropertySubControl( sal_Int32 nType ) : mnType( nType ) {} + explicit PropertySubControl( sal_Int32 nType ) : mnType( nType ) {} virtual ~PropertySubControl(); virtual ::com::sun::star::uno::Any getValue() = 0; @@ -121,7 +121,7 @@ protected: class PropertyControl : public ListBox { public: - PropertyControl( vcl::Window* pParent ); + explicit PropertyControl( vcl::Window* pParent ); virtual ~PropertyControl(); virtual void dispose() override; diff --git a/sd/source/ui/animations/CustomAnimationList.cxx b/sd/source/ui/animations/CustomAnimationList.cxx index 9a24a8c3593e..a423945ba3e6 100644 --- a/sd/source/ui/animations/CustomAnimationList.cxx +++ b/sd/source/ui/animations/CustomAnimationList.cxx @@ -318,7 +318,7 @@ class CustomAnimationListEntry : public SvTreeListEntry { public: CustomAnimationListEntry(); - CustomAnimationListEntry( CustomAnimationEffectPtr pEffect ); + explicit CustomAnimationListEntry( CustomAnimationEffectPtr pEffect ); virtual ~CustomAnimationListEntry(); CustomAnimationEffectPtr getEffect() const { return mpEffect; } @@ -530,7 +530,7 @@ void CustomAnimationList::update( MainSequencePtr pMainSequence ) struct stl_append_effect_func : public std::unary_function<CustomAnimationEffectPtr, void> { - stl_append_effect_func( CustomAnimationList& rList ) : mrList( rList ) {} + explicit stl_append_effect_func( CustomAnimationList& rList ) : mrList( rList ) {} void operator()(CustomAnimationEffectPtr pEffect); CustomAnimationList& mrList; }; diff --git a/sd/source/ui/animations/CustomAnimationList.hxx b/sd/source/ui/animations/CustomAnimationList.hxx index da5ad00c716b..55287fb2f054 100644 --- a/sd/source/ui/animations/CustomAnimationList.hxx +++ b/sd/source/ui/animations/CustomAnimationList.hxx @@ -50,7 +50,7 @@ class CustomAnimationList : public SvTreeListBox, public ISequenceListener friend struct stl_append_effect_func; public: - CustomAnimationList( vcl::Window* pParent ); + explicit CustomAnimationList( vcl::Window* pParent ); virtual ~CustomAnimationList(); virtual void dispose() override; diff --git a/sd/source/ui/animations/SlideTransitionPane.cxx b/sd/source/ui/animations/SlideTransitionPane.cxx index 5493953033f3..21df5d071fe4 100644 --- a/sd/source/ui/animations/SlideTransitionPane.cxx +++ b/sd/source/ui/animations/SlideTransitionPane.cxx @@ -375,7 +375,7 @@ OUString lcl_getSoundFileURL( struct lcl_AppendSoundToListBox : public ::std::unary_function< OUString, void > { - lcl_AppendSoundToListBox( ListBox* rListBox ) : + explicit lcl_AppendSoundToListBox( ListBox* rListBox ) : mrListBox( rListBox ) {} diff --git a/sd/source/ui/animations/motionpathtag.cxx b/sd/source/ui/animations/motionpathtag.cxx index eab900d2f5e9..cf4dca489ae8 100644 --- a/sd/source/ui/animations/motionpathtag.cxx +++ b/sd/source/ui/animations/motionpathtag.cxx @@ -206,7 +206,7 @@ public: maPathPolyPolygon(rPathPolyPolygon) {} - PathDragObjOwn(SdrDragView& rNewView) + explicit PathDragObjOwn(SdrDragView& rNewView) : SdrDragObjOwn(rNewView), maPathPolyPolygon() {} diff --git a/sd/source/ui/annotations/annotationmanagerimpl.hxx b/sd/source/ui/annotations/annotationmanagerimpl.hxx index d2c1d7530f55..bc2f73fb5fff 100644 --- a/sd/source/ui/annotations/annotationmanagerimpl.hxx +++ b/sd/source/ui/annotations/annotationmanagerimpl.hxx @@ -50,7 +50,7 @@ typedef ::cppu::WeakComponentImplHelper < class AnnotationManagerImpl : private ::cppu::BaseMutex, public AnnotationManagerImplBase { public: - AnnotationManagerImpl( ViewShellBase& rViewShellBase ); + explicit AnnotationManagerImpl( ViewShellBase& rViewShellBase ); void init(); diff --git a/sd/source/ui/dlg/RemoteDialog.hxx b/sd/source/ui/dlg/RemoteDialog.hxx index cf84cb944f59..9d2b072a38a3 100644 --- a/sd/source/ui/dlg/RemoteDialog.hxx +++ b/sd/source/ui/dlg/RemoteDialog.hxx @@ -32,7 +32,7 @@ private: DECL_LINK_TYPED( CloseHdl, SystemWindow&, void ); DECL_LINK_TYPED( CloseClickHdl, Button*, void ); public: - RemoteDialog( vcl::Window* pWindow ); + explicit RemoteDialog( vcl::Window* pWindow ); virtual ~RemoteDialog(); virtual void dispose() override; }; diff --git a/sd/source/ui/dlg/RemoteDialogClientBox.hxx b/sd/source/ui/dlg/RemoteDialogClientBox.hxx index 38b7b4e39ec3..7f4de8f6d013 100644 --- a/sd/source/ui/dlg/RemoteDialogClientBox.hxx +++ b/sd/source/ui/dlg/RemoteDialogClientBox.hxx @@ -59,7 +59,7 @@ struct ClientBoxEntry bool m_bActive :1; std::shared_ptr<ClientInfo> m_pClientInfo; - ClientBoxEntry(std::shared_ptr<ClientInfo> pClientInfo); + explicit ClientBoxEntry(std::shared_ptr<ClientInfo> pClientInfo); ~ClientBoxEntry(); }; @@ -73,7 +73,7 @@ class ClientRemovedListener : public ::cppu::WeakImplHelper<css::lang::XEventLis public: - ClientRemovedListener(ClientBox *pParent) + explicit ClientRemovedListener(ClientBox *pParent) { m_pParent = pParent; } diff --git a/sd/source/ui/dlg/dlgass.cxx b/sd/source/ui/dlg/dlgass.cxx index 1ee79055ab1c..726ff7a8d7de 100644 --- a/sd/source/ui/dlg/dlgass.cxx +++ b/sd/source/ui/dlg/dlgass.cxx @@ -93,7 +93,7 @@ public: class NextButton { public: - NextButton (vcl::Window* pParent); + explicit NextButton (vcl::Window* pParent); void ForceFocusEventBroadcast(); void SetClickHdl (const Link<Button*,void>& rLink); diff --git a/sd/source/ui/dlg/headerfooterdlg.cxx b/sd/source/ui/dlg/headerfooterdlg.cxx index 01784bb1fe46..2beecae4806b 100644 --- a/sd/source/ui/dlg/headerfooterdlg.cxx +++ b/sd/source/ui/dlg/headerfooterdlg.cxx @@ -75,7 +75,7 @@ private: void Paint(vcl::RenderContext& rRenderContext, SdrTextObj* pObj, bool bVisible, bool bDotted = false); public: - PresLayoutPreview(vcl::Window* pParent); + explicit PresLayoutPreview(vcl::Window* pParent); virtual ~PresLayoutPreview(); virtual void Paint(vcl::RenderContext& rRenderContext, const Rectangle& rRect) override; diff --git a/sd/source/ui/framework/configuration/ConfigurationControllerBroadcaster.hxx b/sd/source/ui/framework/configuration/ConfigurationControllerBroadcaster.hxx index 049a8703ac0b..c1cc172999b3 100644 --- a/sd/source/ui/framework/configuration/ConfigurationControllerBroadcaster.hxx +++ b/sd/source/ui/framework/configuration/ConfigurationControllerBroadcaster.hxx @@ -43,7 +43,7 @@ class ConfigurationControllerBroadcaster public: /** The given controller is used as origin of thrown exceptions. */ - ConfigurationControllerBroadcaster ( + explicit ConfigurationControllerBroadcaster ( const css::uno::Reference< css::drawing::framework::XConfigurationController>& rxController); diff --git a/sd/source/ui/framework/configuration/ConfigurationUpdater.cxx b/sd/source/ui/framework/configuration/ConfigurationUpdater.cxx index e9e23f08f6d2..9d110e15b00f 100644 --- a/sd/source/ui/framework/configuration/ConfigurationUpdater.cxx +++ b/sd/source/ui/framework/configuration/ConfigurationUpdater.cxx @@ -50,7 +50,7 @@ namespace sd { namespace framework { class ConfigurationUpdaterLock { public: - ConfigurationUpdaterLock (ConfigurationUpdater& rUpdater) + explicit ConfigurationUpdaterLock (ConfigurationUpdater& rUpdater) : mrUpdater(rUpdater) { mrUpdater.LockUpdates(); } ~ConfigurationUpdaterLock() { mrUpdater.UnlockUpdates(); } private: diff --git a/sd/source/ui/framework/configuration/ResourceFactoryManager.hxx b/sd/source/ui/framework/configuration/ResourceFactoryManager.hxx index ffcf61e0fc47..6152e7861bc6 100644 --- a/sd/source/ui/framework/configuration/ResourceFactoryManager.hxx +++ b/sd/source/ui/framework/configuration/ResourceFactoryManager.hxx @@ -39,7 +39,7 @@ namespace sd { namespace framework { class ResourceFactoryManager { public: - ResourceFactoryManager ( + explicit ResourceFactoryManager ( const css::uno::Reference<css::drawing::framework::XControllerManager>& rxManager); ~ResourceFactoryManager(); diff --git a/sd/source/ui/framework/factories/BasicPaneFactory.hxx b/sd/source/ui/framework/factories/BasicPaneFactory.hxx index a91bee8198b4..273e74e8ad96 100644 --- a/sd/source/ui/framework/factories/BasicPaneFactory.hxx +++ b/sd/source/ui/framework/factories/BasicPaneFactory.hxx @@ -64,7 +64,7 @@ class BasicPaneFactory public BasicPaneFactoryInterfaceBase { public: - BasicPaneFactory ( + explicit BasicPaneFactory ( const css::uno::Reference<css::uno::XComponentContext>& rxContext); virtual ~BasicPaneFactory(); diff --git a/sd/source/ui/framework/factories/BasicToolBarFactory.hxx b/sd/source/ui/framework/factories/BasicToolBarFactory.hxx index d44a5d88c976..4a79431373ec 100644 --- a/sd/source/ui/framework/factories/BasicToolBarFactory.hxx +++ b/sd/source/ui/framework/factories/BasicToolBarFactory.hxx @@ -56,7 +56,7 @@ class BasicToolBarFactory public BasicToolBarFactoryInterfaceBase { public: - BasicToolBarFactory ( + explicit BasicToolBarFactory ( const css::uno::Reference<com::sun::star::uno::XComponentContext>& rxContext); virtual ~BasicToolBarFactory(); diff --git a/sd/source/ui/framework/factories/BasicViewFactory.hxx b/sd/source/ui/framework/factories/BasicViewFactory.hxx index 2fc4658dbb6e..1d6eecc6343a 100644 --- a/sd/source/ui/framework/factories/BasicViewFactory.hxx +++ b/sd/source/ui/framework/factories/BasicViewFactory.hxx @@ -71,7 +71,7 @@ class BasicViewFactory public BasicViewFactoryInterfaceBase { public: - BasicViewFactory ( + explicit BasicViewFactory ( const css::uno::Reference<css::uno::XComponentContext>& rxContext); virtual ~BasicViewFactory(); diff --git a/sd/source/ui/framework/factories/PresentationFactory.cxx b/sd/source/ui/framework/factories/PresentationFactory.cxx index 8a9e402a3ea2..c2efde53fd9f 100644 --- a/sd/source/ui/framework/factories/PresentationFactory.cxx +++ b/sd/source/ui/framework/factories/PresentationFactory.cxx @@ -46,7 +46,7 @@ class PresentationFactoryProvider public PresentationFactoryProviderInterfaceBase { public: - PresentationFactoryProvider (const Reference<XComponentContext>& rxContext); + explicit PresentationFactoryProvider (const Reference<XComponentContext>& rxContext); virtual ~PresentationFactoryProvider(); virtual void SAL_CALL disposing() override; @@ -69,7 +69,7 @@ class PresentationView public PresentationViewInterfaceBase { public: - PresentationView (const Reference<XResourceId>& rxViewId) + explicit PresentationView (const Reference<XResourceId>& rxViewId) : PresentationViewInterfaceBase(maMutex),mxResourceId(rxViewId) {}; virtual ~PresentationView() {}; diff --git a/sd/source/ui/framework/module/CenterViewFocusModule.hxx b/sd/source/ui/framework/module/CenterViewFocusModule.hxx index deaf4c2c6dc5..8cf9dd07519e 100644 --- a/sd/source/ui/framework/module/CenterViewFocusModule.hxx +++ b/sd/source/ui/framework/module/CenterViewFocusModule.hxx @@ -54,7 +54,7 @@ class CenterViewFocusModule public CenterViewFocusModuleInterfaceBase { public: - CenterViewFocusModule ( + explicit CenterViewFocusModule ( ::com::sun::star::uno::Reference<com::sun::star::frame::XController>& rxController); virtual ~CenterViewFocusModule(); diff --git a/sd/source/ui/framework/module/ShellStackGuard.hxx b/sd/source/ui/framework/module/ShellStackGuard.hxx index 125087f800a1..9e4b738533eb 100644 --- a/sd/source/ui/framework/module/ShellStackGuard.hxx +++ b/sd/source/ui/framework/module/ShellStackGuard.hxx @@ -64,7 +64,7 @@ class ShellStackGuard public ShellStackGuardInterfaceBase { public: - ShellStackGuard (css::uno::Reference<css::frame::XController>& rxController); + explicit ShellStackGuard (css::uno::Reference<css::frame::XController>& rxController); virtual ~ShellStackGuard(); virtual void SAL_CALL disposing() override; diff --git a/sd/source/ui/framework/module/ToolBarModule.hxx b/sd/source/ui/framework/module/ToolBarModule.hxx index 33a25079eb2f..876362f032e4 100644 --- a/sd/source/ui/framework/module/ToolBarModule.hxx +++ b/sd/source/ui/framework/module/ToolBarModule.hxx @@ -54,7 +54,7 @@ public: @param rxController This is the access point to the drawing framework. */ - ToolBarModule ( + explicit ToolBarModule ( const css::uno::Reference<css::frame::XController>& rxController); virtual ~ToolBarModule(); diff --git a/sd/source/ui/framework/tools/FrameworkHelper.cxx b/sd/source/ui/framework/tools/FrameworkHelper.cxx index 1d081653ea34..1e19d650659b 100644 --- a/sd/source/ui/framework/tools/FrameworkHelper.cxx +++ b/sd/source/ui/framework/tools/FrameworkHelper.cxx @@ -168,7 +168,7 @@ namespace { class FrameworkHelperResourceIdFilter { public: - FrameworkHelperResourceIdFilter ( + explicit FrameworkHelperResourceIdFilter ( const css::uno::Reference<css::drawing::framework::XResourceId>& rxResourceId); bool operator() (const css::drawing::framework::ConfigurationChangeEvent& rEvent) { return mxResourceId.is() && rEvent.ResourceId.is() @@ -296,7 +296,7 @@ class FrameworkHelper::DisposeListener public FrameworkHelperDisposeListenerInterfaceBase { public: - DisposeListener (const ::std::shared_ptr<FrameworkHelper>& rpHelper); + explicit DisposeListener (const ::std::shared_ptr<FrameworkHelper>& rpHelper); virtual ~DisposeListener(); virtual void SAL_CALL disposing() override; @@ -650,7 +650,7 @@ void FrameworkHelper::RunOnResourceActivation( class FlagUpdater { public: - FlagUpdater (bool& rFlag) : mrFlag(rFlag) {} + explicit FlagUpdater (bool& rFlag) : mrFlag(rFlag) {} void operator() (bool) const {mrFlag = true;} private: bool& mrFlag; diff --git a/sd/source/ui/inc/DrawController.hxx b/sd/source/ui/inc/DrawController.hxx index 3af159e1330f..96e5a73f6556 100644 --- a/sd/source/ui/inc/DrawController.hxx +++ b/sd/source/ui/inc/DrawController.hxx @@ -57,7 +57,7 @@ typedef ::cppu::ImplInheritanceHelper < class BroadcastHelperOwner { public: - BroadcastHelperOwner (::osl::Mutex& rMutex) : maBroadcastHelper(rMutex) {}; + explicit BroadcastHelperOwner (::osl::Mutex& rMutex) : maBroadcastHelper(rMutex) {}; ::cppu::OBroadcastHelper maBroadcastHelper; }; @@ -97,7 +97,7 @@ public: /** Create a new DrawController object for the given ViewShellBase. */ - DrawController (ViewShellBase& rBase) throw(); + explicit DrawController (ViewShellBase& rBase) throw(); virtual ~DrawController() throw(); diff --git a/sd/source/ui/inc/TabControl.hxx b/sd/source/ui/inc/TabControl.hxx index fe0d9216fece..6054b441f3e5 100644 --- a/sd/source/ui/inc/TabControl.hxx +++ b/sd/source/ui/inc/TabControl.hxx @@ -84,7 +84,7 @@ private: class TabControlTransferable : public TransferableHelper { public: - TabControlTransferable( TabControl& rParent ) : + explicit TabControlTransferable( TabControl& rParent ) : mrParent( rParent ) {} private: diff --git a/sd/source/ui/inc/optsitem.hxx b/sd/source/ui/inc/optsitem.hxx index c55ac3080461..d50bad692452 100644 --- a/sd/source/ui/inc/optsitem.hxx +++ b/sd/source/ui/inc/optsitem.hxx @@ -144,7 +144,7 @@ class SD_DLLPUBLIC SdOptionsLayoutItem : public SfxPoolItem { public: - SdOptionsLayoutItem( sal_uInt16 nWhich); + explicit SdOptionsLayoutItem( sal_uInt16 nWhich); SdOptionsLayoutItem( sal_uInt16 nWhich, SdOptions* pOpts, ::sd::FrameView* pView = NULL ); virtual SfxPoolItem* Clone( SfxItemPool *pPool = 0 ) const override; @@ -320,7 +320,7 @@ class SD_DLLPUBLIC SdOptionsMiscItem : public SfxPoolItem { public: - SdOptionsMiscItem( sal_uInt16 nWhich); + explicit SdOptionsMiscItem( sal_uInt16 nWhich); SdOptionsMiscItem( sal_uInt16 nWhich, SdOptions* pOpts, ::sd::FrameView* pView = NULL ); virtual SfxPoolItem* Clone( SfxItemPool *pPool = 0 ) const override; @@ -389,7 +389,7 @@ class SD_DLLPUBLIC SdOptionsSnapItem : public SfxPoolItem { public: - SdOptionsSnapItem( sal_uInt16 nWhich); + explicit SdOptionsSnapItem( sal_uInt16 nWhich); SdOptionsSnapItem( sal_uInt16 nWhich, SdOptions* pOpts, ::sd::FrameView* pView = NULL ); virtual SfxPoolItem* Clone( SfxItemPool *pPool = 0 ) const override; @@ -562,7 +562,7 @@ class SD_DLLPUBLIC SdOptionsPrintItem : public SfxPoolItem { public: - SdOptionsPrintItem( sal_uInt16 nWhich); + explicit SdOptionsPrintItem( sal_uInt16 nWhich); SdOptionsPrintItem( sal_uInt16 nWhich, SdOptions* pOpts, ::sd::FrameView* pView = NULL ); virtual SfxPoolItem* Clone( SfxItemPool *pPool = 0 ) const override; @@ -583,7 +583,7 @@ class SdOptions : public SdOptionsLayout, public SdOptionsContents, { public: - SdOptions( sal_uInt16 nConfigId ); + explicit SdOptions( sal_uInt16 nConfigId ); virtual ~SdOptions(); void StoreConfig(); diff --git a/sd/source/ui/presenter/PresenterHelper.hxx b/sd/source/ui/presenter/PresenterHelper.hxx index d03e7c259169..0abe0861b537 100644 --- a/sd/source/ui/presenter/PresenterHelper.hxx +++ b/sd/source/ui/presenter/PresenterHelper.hxx @@ -45,7 +45,7 @@ class PresenterHelper public PresenterHelperInterfaceBase { public: - PresenterHelper (const css::uno::Reference<css::uno::XComponentContext>& rxContext); + explicit PresenterHelper (const css::uno::Reference<css::uno::XComponentContext>& rxContext); virtual ~PresenterHelper(); // XInitialize diff --git a/sd/source/ui/presenter/PresenterPreviewCache.hxx b/sd/source/ui/presenter/PresenterPreviewCache.hxx index aa62b209571b..6424185a446b 100644 --- a/sd/source/ui/presenter/PresenterPreviewCache.hxx +++ b/sd/source/ui/presenter/PresenterPreviewCache.hxx @@ -46,7 +46,7 @@ class PresenterPreviewCache public PresenterPreviewCacheInterfaceBase { public: - PresenterPreviewCache (const css::uno::Reference<css::uno::XComponentContext>& rxContext); + explicit PresenterPreviewCache (const css::uno::Reference<css::uno::XComponentContext>& rxContext); virtual ~PresenterPreviewCache(); // XInitialize diff --git a/sd/source/ui/remotecontrol/BluetoothServer.hxx b/sd/source/ui/remotecontrol/BluetoothServer.hxx index 8a8519431420..ac0fe3c8e665 100644 --- a/sd/source/ui/remotecontrol/BluetoothServer.hxx +++ b/sd/source/ui/remotecontrol/BluetoothServer.hxx @@ -40,7 +40,7 @@ namespace sd void addCommunicator( Communicator* pCommunicator ); #endif private: - BluetoothServer( std::vector<Communicator*>* pCommunicators ); + explicit BluetoothServer( std::vector<Communicator*>* pCommunicators ); virtual ~BluetoothServer(); enum { UNKNOWN, DISCOVERABLE, NOT_DISCOVERABLE } meWasDiscoverable; diff --git a/sd/source/ui/remotecontrol/BufferedStreamSocket.hxx b/sd/source/ui/remotecontrol/BufferedStreamSocket.hxx index 5a1c2fcf4b8d..bf27fd02b9bf 100644 --- a/sd/source/ui/remotecontrol/BufferedStreamSocket.hxx +++ b/sd/source/ui/remotecontrol/BufferedStreamSocket.hxx @@ -36,11 +36,11 @@ namespace sd * Create a BufferedStreamSocket on top of an * osl::StreamSocket. */ - BufferedStreamSocket( const osl::StreamSocket &aSocket ); + explicit BufferedStreamSocket( const osl::StreamSocket &aSocket ); /** * Create a BufferedStreamSocket on top of a POSIX or WinSock socket. */ - BufferedStreamSocket( int aSocket ); + explicit BufferedStreamSocket( int aSocket ); BufferedStreamSocket( const BufferedStreamSocket &aSocket ); /** * Blocks until a line is read. diff --git a/sd/source/ui/remotecontrol/Communicator.hxx b/sd/source/ui/remotecontrol/Communicator.hxx index 6f92b6677c0f..4965c4381dda 100644 --- a/sd/source/ui/remotecontrol/Communicator.hxx +++ b/sd/source/ui/remotecontrol/Communicator.hxx @@ -38,7 +38,7 @@ namespace sd class Communicator : public salhelper::Thread { public: - Communicator( IBluetoothSocket *pSocket ); + explicit Communicator( IBluetoothSocket *pSocket ); virtual ~Communicator(); void presentationStarted( const css::uno::Reference< diff --git a/sd/source/ui/remotecontrol/Receiver.hxx b/sd/source/ui/remotecontrol/Receiver.hxx index 2c643f7e7ff1..99d8a2f366e5 100644 --- a/sd/source/ui/remotecontrol/Receiver.hxx +++ b/sd/source/ui/remotecontrol/Receiver.hxx @@ -31,7 +31,7 @@ class Receiver : Timer { std::deque< std::vector< OString > > maExecQueue; public: - Receiver( Transmitter *aTransmitter ); + explicit Receiver( Transmitter *aTransmitter ); virtual ~Receiver(); virtual void Invoke() override; void pushCommand( const std::vector<OString> &rCommand ); diff --git a/sd/source/ui/remotecontrol/Transmitter.hxx b/sd/source/ui/remotecontrol/Transmitter.hxx index 9fcbe70660ab..3deb6442f944 100644 --- a/sd/source/ui/remotecontrol/Transmitter.hxx +++ b/sd/source/ui/remotecontrol/Transmitter.hxx @@ -26,7 +26,7 @@ class Transmitter { public: enum Priority { PRIORITY_LOW = 1, PRIORITY_HIGH }; - Transmitter( ::sd::IBluetoothSocket* aSocket ); + explicit Transmitter( ::sd::IBluetoothSocket* aSocket ); virtual ~Transmitter(); void addMessage( const OString& aMessage, const Priority aPriority ); void notifyFinished(); diff --git a/sd/source/ui/sidebar/MasterPageContainerFiller.hxx b/sd/source/ui/sidebar/MasterPageContainerFiller.hxx index 6fb2091f0ab1..6b4b7c7cf21d 100644 --- a/sd/source/ui/sidebar/MasterPageContainerFiller.hxx +++ b/sd/source/ui/sidebar/MasterPageContainerFiller.hxx @@ -53,7 +53,7 @@ public: ~ContainerAdapter() {} }; - MasterPageContainerFiller (ContainerAdapter& rContainerAdapter); + explicit MasterPageContainerFiller (ContainerAdapter& rContainerAdapter); virtual ~MasterPageContainerFiller(); /** Run the next step of the task. After HasNextStep() returns false diff --git a/sd/source/ui/sidebar/MasterPageContainerProviders.hxx b/sd/source/ui/sidebar/MasterPageContainerProviders.hxx index d5fcd3716bec..04001d19c062 100644 --- a/sd/source/ui/sidebar/MasterPageContainerProviders.hxx +++ b/sd/source/ui/sidebar/MasterPageContainerProviders.hxx @@ -113,7 +113,7 @@ private: class TemplatePageObjectProvider : public PageObjectProvider { public: - TemplatePageObjectProvider (const OUString& rsURL); + explicit TemplatePageObjectProvider (const OUString& rsURL); virtual ~TemplatePageObjectProvider() {}; virtual SdPage* operator () (SdDrawDocument* pDocument) override; virtual int GetCostIndex() override; @@ -130,7 +130,7 @@ private: class TemplatePreviewProvider : public PreviewProvider { public: - TemplatePreviewProvider (const OUString& rsURL); + explicit TemplatePreviewProvider (const OUString& rsURL); virtual ~TemplatePreviewProvider() {}; virtual Image operator() (int nWidth, SdPage* pPage, ::sd::PreviewRenderer& rRenderer) override; virtual int GetCostIndex() override; @@ -157,7 +157,7 @@ public: class ExistingPageProvider : public PageObjectProvider { public: - ExistingPageProvider (SdPage* pPage); + explicit ExistingPageProvider (SdPage* pPage); virtual ~ExistingPageProvider() {} virtual SdPage* operator() (SdDrawDocument* pDocument) override; virtual int GetCostIndex() override; diff --git a/sd/source/ui/sidebar/MasterPageContainerQueue.cxx b/sd/source/ui/sidebar/MasterPageContainerQueue.cxx index 0f6906759746..65a5af93ba1a 100644 --- a/sd/source/ui/sidebar/MasterPageContainerQueue.cxx +++ b/sd/source/ui/sidebar/MasterPageContainerQueue.cxx @@ -62,9 +62,9 @@ public: }; class CompareToken { - public: + public: MasterPageContainer::Token maToken; - CompareToken(MasterPageContainer::Token aToken) : maToken(aToken) {} + explicit CompareToken(MasterPageContainer::Token aToken) : maToken(aToken) {} bool operator() (const PreviewCreationRequest& rRequest) const { return maToken==rRequest.mpDescriptor->maToken; } }; diff --git a/sd/source/ui/sidebar/MasterPageContainerQueue.hxx b/sd/source/ui/sidebar/MasterPageContainerQueue.hxx index e8b1553ac546..516c3d4f5e01 100644 --- a/sd/source/ui/sidebar/MasterPageContainerQueue.hxx +++ b/sd/source/ui/sidebar/MasterPageContainerQueue.hxx @@ -114,7 +114,7 @@ private: */ static sal_uInt32 snWaitForMoreRequestsCount; - MasterPageContainerQueue (const std::weak_ptr<ContainerAdapter>& rpContainer); + explicit MasterPageContainerQueue (const std::weak_ptr<ContainerAdapter>& rpContainer); void LateInit(); /** Calculate the priority that defines the order in which requests diff --git a/sd/source/ui/slideshow/slideshowimpl.hxx b/sd/source/ui/slideshow/slideshowimpl.hxx index baed5ef503b3..032953001cfa 100644 --- a/sd/source/ui/slideshow/slideshowimpl.hxx +++ b/sd/source/ui/slideshow/slideshowimpl.hxx @@ -97,7 +97,7 @@ struct PresentationSettingsEx : public PresentationSettings css::uno::Reference< css::animations::XAnimationNode > mxAnimationNode; PresentationSettingsEx( const PresentationSettingsEx& ); - PresentationSettingsEx( PresentationSettings& ); + explicit PresentationSettingsEx( PresentationSettings& ); void SetArguments( const css::uno::Sequence< css::beans::PropertyValue >& rArguments ) throw (css::lang::IllegalArgumentException, std::exception); diff --git a/sd/source/ui/slidesorter/cache/SlsBitmapCache.hxx b/sd/source/ui/slidesorter/cache/SlsBitmapCache.hxx index 12145275ecab..53716ee8fe57 100644 --- a/sd/source/ui/slidesorter/cache/SlsBitmapCache.hxx +++ b/sd/source/ui/slidesorter/cache/SlsBitmapCache.hxx @@ -63,7 +63,7 @@ public: When that does not exist either then a internal default value is used. */ - BitmapCache (const sal_Int32 nMaximalNormalCacheSize = 0); + explicit BitmapCache (const sal_Int32 nMaximalNormalCacheSize = 0); /** The destructor clears the cache and releases all bitmaps still in it. */ diff --git a/sd/source/ui/slidesorter/cache/SlsBitmapCompressor.cxx b/sd/source/ui/slidesorter/cache/SlsBitmapCompressor.cxx index 7f93e41c4c6a..92b54c8c12d8 100644 --- a/sd/source/ui/slidesorter/cache/SlsBitmapCompressor.cxx +++ b/sd/source/ui/slidesorter/cache/SlsBitmapCompressor.cxx @@ -38,7 +38,7 @@ public: Bitmap maPreview; Size maOriginalSize; - DummyReplacement (const Bitmap& rPreview) : maPreview(rPreview) { } + explicit DummyReplacement (const Bitmap& rPreview) : maPreview(rPreview) { } virtual ~DummyReplacement() {} virtual sal_Int32 GetMemorySize() const override { return maPreview.GetSizeBytes(); } }; diff --git a/sd/source/ui/slidesorter/cache/SlsPageCacheManager.cxx b/sd/source/ui/slidesorter/cache/SlsPageCacheManager.cxx index 0e639944a58e..3a751df9c679 100644 --- a/sd/source/ui/slidesorter/cache/SlsPageCacheManager.cxx +++ b/sd/source/ui/slidesorter/cache/SlsPageCacheManager.cxx @@ -85,7 +85,7 @@ typedef ::std::deque<RecentlyUsedCacheDescriptor> RecentlyUsedQueue; class BestFittingCacheComparer { public: - BestFittingCacheComparer (const Size& rPreferredSize) + explicit BestFittingCacheComparer (const Size& rPreferredSize) : maPreferredSize(rPreferredSize) {} bool operator()(const ::sd::slidesorter::cache::PageCacheManager::BestFittingPageCaches::value_type& rElement1, @@ -123,7 +123,7 @@ public: address only. */ class CompareWithCache { public: - CompareWithCache(const std::shared_ptr<PageCacheManager::Cache>& rpCache) + explicit CompareWithCache(const std::shared_ptr<PageCacheManager::Cache>& rpCache) : mpCache(rpCache) {} bool operator () (const PageCacheContainer::value_type& rValue) const { return rValue.second == mpCache; } diff --git a/sd/source/ui/slidesorter/cache/SlsRequestQueue.cxx b/sd/source/ui/slidesorter/cache/SlsRequestQueue.cxx index b46a593f94b2..d6fb03b1b274 100644 --- a/sd/source/ui/slidesorter/cache/SlsRequestQueue.cxx +++ b/sd/source/ui/slidesorter/cache/SlsRequestQueue.cxx @@ -56,7 +56,7 @@ public: class DataComparator { public: - DataComparator (const CacheKey aKey) + explicit DataComparator (const CacheKey aKey) : maKey(aKey) { } diff --git a/sd/source/ui/slidesorter/cache/SlsRequestQueue.hxx b/sd/source/ui/slidesorter/cache/SlsRequestQueue.hxx index 01e278db5bfa..3410ae841643 100644 --- a/sd/source/ui/slidesorter/cache/SlsRequestQueue.hxx +++ b/sd/source/ui/slidesorter/cache/SlsRequestQueue.hxx @@ -38,7 +38,7 @@ class RequestData; class RequestQueue : public sdr::PageUser { public: - RequestQueue (const SharedCacheContext& rpCacheContext); + explicit RequestQueue (const SharedCacheContext& rpCacheContext); virtual ~RequestQueue(); /** Insert a request with highest or lowest priority in its priority diff --git a/sd/source/ui/slidesorter/controller/SlsClipboard.cxx b/sd/source/ui/slidesorter/controller/SlsClipboard.cxx index 2ef25e5b5d48..99278b1c6613 100644 --- a/sd/source/ui/slidesorter/controller/SlsClipboard.cxx +++ b/sd/source/ui/slidesorter/controller/SlsClipboard.cxx @@ -86,7 +86,7 @@ namespace { class TemporarySlideTrackingDeactivator { public: - TemporarySlideTrackingDeactivator (SlideSorterController& rController) + explicit TemporarySlideTrackingDeactivator (SlideSorterController& rController) : mrController(rController), mbIsCurrentSlideTrackingActive ( mrController.GetVisibleAreaManager().IsCurrentSlideTrackingActive()) diff --git a/sd/source/ui/slidesorter/controller/SlsDragAndDropContext.hxx b/sd/source/ui/slidesorter/controller/SlsDragAndDropContext.hxx index c7f6f1ee6c57..58709200ba8d 100644 --- a/sd/source/ui/slidesorter/controller/SlsDragAndDropContext.hxx +++ b/sd/source/ui/slidesorter/controller/SlsDragAndDropContext.hxx @@ -42,7 +42,7 @@ public: /** Create a substitution display of the currently selected pages or, when provided, the pages in the transferable. */ - DragAndDropContext (SlideSorter& rSlideSorter); + explicit DragAndDropContext (SlideSorter& rSlideSorter); ~DragAndDropContext(); /** Call this method (for example as reaction to ESC key press) to avoid diff --git a/sd/source/ui/slidesorter/controller/SlsListener.hxx b/sd/source/ui/slidesorter/controller/SlsListener.hxx index 949fe97b5df5..f281cdaadec9 100644 --- a/sd/source/ui/slidesorter/controller/SlsListener.hxx +++ b/sd/source/ui/slidesorter/controller/SlsListener.hxx @@ -71,7 +71,7 @@ class Listener public SfxListener { public: - Listener (SlideSorter& rSlideSorter); + explicit Listener (SlideSorter& rSlideSorter); virtual ~Listener(); /** Connect to the current controller of the view shell as listener. diff --git a/sd/source/ui/view/ViewShellBase.cxx b/sd/source/ui/view/ViewShellBase.cxx index 966e7772f1c2..7fc8354905f1 100644 --- a/sd/source/ui/view/ViewShellBase.cxx +++ b/sd/source/ui/view/ViewShellBase.cxx @@ -101,7 +101,7 @@ namespace { class CurrentPageSetter { public: - CurrentPageSetter (ViewShellBase& rBase); + explicit CurrentPageSetter (ViewShellBase& rBase); void operator () (bool); private: ViewShellBase& mrBase; @@ -146,7 +146,7 @@ public: std::shared_ptr<tools::EventMultiplexer> mpEventMultiplexer; std::shared_ptr<FormShellManager> mpFormShellManager; - Implementation (ViewShellBase& rBase); + explicit Implementation (ViewShellBase& rBase); ~Implementation(); void LateInit(); |