simplify calls to *DialogFactory::Create methods

we don't need to check for nullptr here, it's never null.

Change-Id: I3cc5337a8f4dec6747821679e39ccba3cec20f56
Reviewed-on: https://gerrit.libreoffice.org/55114
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 13 insertions, 18 deletions

diff --git a/sd/source/ui/func/fucopy.cxx b/sd/source/ui/func/fucopy.cxx
index a8cde2135f49..e6b1c95f35e2 100644
--- a/sd/source/ui/func/fucopy.cxx
+++ b/sd/source/ui/func/fucopy.cxx
@@ -99,27 +99,22 @@ void FuCopy::DoExecute( SfxRequest& rReq )
             }
 
             SdAbstractDialogFactory* pFact = SdAbstractDialogFactory::Create();
-            if( pFact )
-            {
-                ScopedVclPtr<AbstractCopyDlg> pDlg(pFact->CreateCopyDlg(mpViewShell->GetActiveWindow(), aSet, mpView ));
-                if (!pDlg)
-                    return;
+            ScopedVclPtr<AbstractCopyDlg> pDlg(pFact->CreateCopyDlg(mpViewShell->GetActiveWindow(), aSet, mpView ));
 
-                sal_uInt16 nResult = pDlg->Execute();
+            sal_uInt16 nResult = pDlg->Execute();
 
-                switch( nResult )
-                {
-                    case RET_OK:
-                        pDlg->GetAttr( aSet );
-                        rReq.Done( aSet );
-                        pArgs = rReq.GetArgs();
-                    break;
+            switch( nResult )
+            {
+                case RET_OK:
+                    pDlg->GetAttr( aSet );
+                    rReq.Done( aSet );
+                    pArgs = rReq.GetArgs();
+                break;
 
-                    default:
-                    {
-                        pDlg.disposeAndClear();
-                        mpView->EndUndo();
-                    }
+                default:
+                {
+                    pDlg.disposeAndClear();
+                    mpView->EndUndo();
                     return; // Cancel
                 }
             }