Find places where OUString and OString are passed by value.

It's not very efficient, because we generally end up copying it twice -
once into the parameter and again into the destination OUString.

So I create a clang plugin that finds such places and generates a
warning so that we can convert them to pass-by-reference.

Change-Id: I5341a6ea9e3190f4b4c05c42c85595e3dcd83361

1 files changed, 2 insertions, 2 deletions

diff --git a/scripting/source/stringresource/stringresource.hxx b/scripting/source/stringresource/stringresource.hxx
index 0e7309eb69cb..87e4732101de 100644
--- a/scripting/source/stringresource/stringresource.hxx
+++ b/scripting/source/stringresource/stringresource.hxx
@@ -55,7 +55,7 @@ namespace stringresource
 // Hashtable to map string ids to string
 struct hashName_Impl
 {
-    size_t operator()(const OUString Str) const
+    size_t operator()(const OUString& Str) const
     {
         return (size_t)Str.hashCode();
     }
@@ -63,7 +63,7 @@ struct hashName_Impl
 
 struct eqName_Impl
 {
-    sal_Bool operator()(const OUString Str1, const OUString Str2) const
+    sal_Bool operator()(const OUString& Str1, const OUString& Str2) const
     {
         return ( Str1 == Str2 );
     }