simplify "a = a +" to "a +="

mostly so that my stringadd loplugin can point out places to improve

Change-Id: I9920ee1c99cdb6b811ba67ff9d8e32aa261884b5
Reviewed-on: https://gerrit.libreoffice.org/80618
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

6 files changed, 9 insertions, 9 deletions

diff --git a/sc/source/core/data/attrib.cxx b/sc/source/core/data/attrib.cxx
index 5f1517250998..94a8922e334e 100644
--- a/sc/source/core/data/attrib.cxx
+++ b/sc/source/core/data/attrib.cxx
@@ -610,7 +610,7 @@ bool ScPageScaleToItem::GetPresentation(
     OUString aName( ScResId( STR_SCATTR_PAGE_SCALETO ) );
     OUString aValue( ScResId( STR_SCATTR_PAGE_SCALE_WIDTH ) );
     lclAppendScalePageCount( aValue, mnWidth );
-    aValue = aValue + ", " + ScResId( STR_SCATTR_PAGE_SCALE_HEIGHT );
+    aValue += ", " + ScResId( STR_SCATTR_PAGE_SCALE_HEIGHT );
     lclAppendScalePageCount( aValue, mnHeight );
 
     switch( ePres )
diff --git a/sc/source/core/data/docpool.cxx b/sc/source/core/data/docpool.cxx
index 95597eb2a61b..ce98a6ea45a5 100644
--- a/sc/source/core/data/docpool.cxx
+++ b/sc/source/core/data/docpool.cxx
@@ -429,7 +429,7 @@ static bool lcl_HFPresentation
                 aText = EditResId(RID_SVXITEMS_LRSPACE_LEFT);
                 if ( 100 != nPropLeftMargin )
                 {
-                    aText = aText + unicode::formatPercent(nPropLeftMargin,
+                    aText += unicode::formatPercent(nPropLeftMargin,
                         Application::GetSettings().GetUILanguageTag());
                 }
                 else
@@ -443,7 +443,7 @@ static bool lcl_HFPresentation
                     EditResId(RID_SVXITEMS_LRSPACE_RIGHT);
                 if ( 100 != nPropRightMargin )
                 {
-                    aText = aText + unicode::formatPercent(nPropLeftMargin,
+                    aText += unicode::formatPercent(nPropLeftMargin,
                         Application::GetSettings().GetUILanguageTag());
                 }
                 else
@@ -462,7 +462,7 @@ static bool lcl_HFPresentation
 
         if ( aText.getLength() )
         {
-            rText = rText + aText + " + ";
+            rText += aText + " + ";
         }
     }
 
@@ -559,7 +559,7 @@ bool ScDocumentPool::GetPresentation(
             if( nPercent )
             {
                 rText = ScResId(STR_SCATTR_PAGE_SCALE) + aStrSep;
-                rText = rText + unicode::formatPercent(nPercent,
+                rText += unicode::formatPercent(nPercent,
                     Application::GetSettings().GetUILanguageTag());
             }
             else
diff --git a/sc/source/core/opencl/formulagroupcl.cxx b/sc/source/core/opencl/formulagroupcl.cxx
index 8948160c4695..05deff486faa 100644
--- a/sc/source/core/opencl/formulagroupcl.cxx
+++ b/sc/source/core/opencl/formulagroupcl.cxx
@@ -2583,7 +2583,7 @@ public:
     {
         std::string t = "_" + mpCodeGen->BinFuncName();
         for (const auto & rSubArgument : mvSubArguments)
-            t = t + rSubArgument->DumpOpName();
+            t += rSubArgument->DumpOpName();
         return t;
     }
     virtual void DumpInlineFun( std::set<std::string>& decls,
diff --git a/sc/source/filter/excel/xecontent.cxx b/sc/source/filter/excel/xecontent.cxx
index c61425647e59..fc354d0ba69b 100644
--- a/sc/source/filter/excel/xecontent.cxx
+++ b/sc/source/filter/excel/xecontent.cxx
@@ -1255,7 +1255,7 @@ OString createHexStringFromDigit(sal_uInt8 nDigit)
 {
     OString aString = OString::number( nDigit, 16 );
     if(aString.getLength() == 1)
-        aString = aString + OString::number(0);
+        aString += OString::number(0);
     return aString;
 }
 
diff --git a/sc/source/ui/app/inputhdl.cxx b/sc/source/ui/app/inputhdl.cxx
index e7090c108bbd..111c57d9f105 100644
--- a/sc/source/ui/app/inputhdl.cxx
+++ b/sc/source/ui/app/inputhdl.cxx
@@ -1592,7 +1592,7 @@ static OUString lcl_Calculate( const OUString& rFormula, ScDocument* pDoc, const
 
     ScRange aTestRange;
     if ( bColRowName || (aTestRange.Parse(rFormula) & ScRefFlags::VALID) )
-        aValue = aValue + " ...";
+        aValue += " ...";
 
     return aValue;
 }
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index 06f74bab50bd..18c83970a895 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -2282,7 +2282,7 @@ void ScGridWindow::MouseButtonUp( const MouseEvent& rMEvt )
                 if ( aScRange.aStart == aScRange.aEnd )
                 {
                     //  make sure there is a range selection string even for a single cell
-                    aAddr = aAddr + ":" + aAddr;
+                    aAddr += ":" + aAddr;
                 }
 
                 //! SID_MARKAREA does not exist anymore ???