summaryrefslogtreecommitdiff
path: root/sc
diff options
context:
space:
mode:
authorKohei Yoshida <kohei.yoshida@collabora.com>2014-07-17 15:52:52 -0400
committerKohei Yoshida <kohei.yoshida@collabora.com>2014-07-17 18:45:51 -0400
commit0bb67e725d2e323bd6a9fa71e0094c21eb019c80 (patch)
treef735e41a7f198a00bce7849c4de425d94abe3c56 /sc
parent7c76ada0f4a45b4b6375d33e2eada739ddb2fd88 (diff)
fdo#81470: Fix a crasher during xlsx export with revisions.
Calling Undo() here removes revision entries which also removes formula cell instances stored in the entries. The problem is that the XclExpChTrCellContent instances store pointers to these formula instances for later use, and removing the entries at this location causes deleted formula instances to get accessed which in turn causes segfault. Since all revision entries get deleted when the temp change track instance gets deleted at the end of the revision export, not deleting the entries here will not cause memory leaks. Change-Id: I85f8064945a841b684e4fc4a97c3f9bb6a2de353 (cherry picked from commit 3bce16799c34d0b28704c43eae77501c0f6aec1e)
Diffstat (limited to 'sc')
-rw-r--r--sc/source/filter/xcl97/XclExpChangeTrack.cxx1
1 files changed, 0 insertions, 1 deletions
diff --git a/sc/source/filter/xcl97/XclExpChangeTrack.cxx b/sc/source/filter/xcl97/XclExpChangeTrack.cxx
index 9682964b068f..3a3655d32c05 100644
--- a/sc/source/filter/xcl97/XclExpChangeTrack.cxx
+++ b/sc/source/filter/xcl97/XclExpChangeTrack.cxx
@@ -1454,7 +1454,6 @@ XclExpChangeTrack::XclExpChangeTrack( const XclExpRoot& rRoot ) :
{
PushActionRecord( *pScAction );
const ScChangeAction* pPrevAction = pScAction->GetPrev();
- pTempChangeTrack->Undo( pScAction->GetActionNumber(), pScAction->GetActionNumber() );
pScAction = pPrevAction;
}