diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2015-03-10 13:07:45 +0000 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2015-03-10 15:44:58 +0000 |
| commit | b6d6dab920a9e14a6fe9c61446da64ab62dcbfdf (patch) | |
| tree | 0b80eb631d6869ad1c3c06857909c08c9f5d3480 /sc/source/ui/namedlg/namedefdlg.cxx | |
| parent | 441523b0df8983fb34409a5f4e25dde571be1af7 (diff) | |
V668 no sense in testing the result of new against null
Change-Id: I1cff71d15f4d1b5ee47cc734b3fc2168d7f99201
Diffstat (limited to 'sc/source/ui/namedlg/namedefdlg.cxx')
| -rw-r--r-- | sc/source/ui/namedlg/namedefdlg.cxx | 19 |
1 files changed, 8 insertions, 11 deletions
diff --git a/sc/source/ui/namedlg/namedefdlg.cxx b/sc/source/ui/namedlg/namedefdlg.cxx index 43b4ecc6182c..b784e93ddddb 100644 --- a/sc/source/ui/namedlg/namedefdlg.cxx +++ b/sc/source/ui/namedlg/namedefdlg.cxx @@ -204,23 +204,20 @@ void ScNameDefDlg::AddPushed() { if ( mpDoc ) { - ScRangeData* pNewEntry = NULL; RangeType nType = RT_NAME; - pNewEntry = new ScRangeData( mpDoc, + ScRangeData* pNewEntry = new ScRangeData( mpDoc, aName, aExpression, maCursorPos, nType ); - if (pNewEntry) - { - nType = nType - | (m_pBtnRowHeader->IsChecked() ? RT_ROWHEADER : RangeType(0)) - | (m_pBtnColHeader->IsChecked() ? RT_COLHEADER : RangeType(0)) - | (m_pBtnPrintArea->IsChecked() ? RT_PRINTAREA : RangeType(0)) - | (m_pBtnCriteria->IsChecked() ? RT_CRITERIA : RangeType(0)); - pNewEntry->AddType(nType); - } + + nType = nType + | (m_pBtnRowHeader->IsChecked() ? RT_ROWHEADER : RangeType(0)) + | (m_pBtnColHeader->IsChecked() ? RT_COLHEADER : RangeType(0)) + | (m_pBtnPrintArea->IsChecked() ? RT_PRINTAREA : RangeType(0)) + | (m_pBtnCriteria->IsChecked() ? RT_CRITERIA : RangeType(0)); + pNewEntry->AddType(nType); // aExpression valid? if ( 0 == pNewEntry->GetErrCode() ) |