clang-tidy clang-analyzer-deadcode.DeadStores

suspect that some of these may reveal latent bugs....

Change-Id: I9de9aabbda9c8952715631577c29c1830df1eb71
Reviewed-on: https://gerrit.libreoffice.org/24200
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

1 files changed, 2 insertions, 6 deletions

diff --git a/sc/source/ui/miscdlgs/acredlin.cxx b/sc/source/ui/miscdlgs/acredlin.cxx
index b69939b327b8..6abac7366c61 100644
--- a/sc/source/ui/miscdlgs/acredlin.cxx
+++ b/sc/source/ui/miscdlgs/acredlin.cxx
@@ -1339,11 +1339,7 @@ IMPL_LINK_TYPED( ScAcceptChgDlg, ExpandingHandle, SvTreeListBox*, pTable, bool )
         SvTreeListEntry* pEntry=pTheView->GetHdlEntry();
         if(pEntry!=nullptr)
         {
-            ScChangeAction* pScChangeAction=nullptr;
-
             ScRedlinData *pEntryData=static_cast<ScRedlinData *>(pEntry->GetUserData());
-            if(pEntryData!=nullptr)
-                pScChangeAction=static_cast<ScChangeAction*>(pEntryData->pData);
 
             if(pEntry->HasChildrenOnDemand())
             {
@@ -1355,7 +1351,7 @@ IMPL_LINK_TYPED( ScAcceptChgDlg, ExpandingHandle, SvTreeListBox*, pTable, bool )
 
                 if(pEntryData!=nullptr)
                 {
-                    pScChangeAction=static_cast<ScChangeAction*>(pEntryData->pData);
+                    ScChangeAction* pScChangeAction=static_cast<ScChangeAction*>(pEntryData->pData);
 
                     GetDependents( pScChangeAction, aActionMap, pEntry );
 
@@ -1525,7 +1521,6 @@ void ScAcceptChgDlg::UpdateEntrys(ScChangeTrack* pChgTrack, sal_uLong nStartActi
 
 
     SvTreeListEntry* pEntry=pTheView->First();
-    SvTreeListEntry* pNextEntry = (pEntry ? SvTreeListBox::NextSibling(pEntry) : nullptr);
     SvTreeListEntry* pLastEntry=nullptr;
     while(pEntry!=nullptr)
     {
@@ -1541,6 +1536,7 @@ void ScAcceptChgDlg::UpdateEntrys(ScChangeTrack* pChgTrack, sal_uLong nStartActi
             if(nStartAction<=nAction && nAction<=nEndAction) bRemove=true;
         }
 
+        SvTreeListEntry* pNextEntry;
         if(bRemove)
         {
             nPos=pEntry->GetChildListPos();