Improve OpenCL logging and warnings

Explicitly catch and report the 'Unhandled' and 'OpenCLError'
exceptions, too, in DynamicKernel::create, instead of relying on a
catch(...).

(Actually not sure why we need three separate classes of OpenCL
handling exceptions.)

We have the code to show the file and line where something exceptional
(or actually not so exceptional) happens with OpenCL, so make use of
that then.

It is a perfectly normal thing to throw (and catch) at least the
UnhandledToken and Unhandled exceptions (when compiling a formula and
noticing that we don't want to use OpenCL for it after all), so it
does not make sense SAL_WARN about them. Just SAL_INFO is fine.

Change-Id: I56770f47622cb4bc40f2216c5e78d3da3c7c9adf

1 files changed, 2 insertions, 2 deletions

diff --git a/sc/source/core/opencl/opbase.hxx b/sc/source/core/opencl/opbase.hxx
index 94c15749a95a..2984f1cf2785 100644
--- a/sc/source/core/opencl/opbase.hxx
+++ b/sc/source/core/opencl/opbase.hxx
@@ -31,7 +31,7 @@ class FormulaTreeNode;
 class UnhandledToken
 {
 public:
-    UnhandledToken( const char* m, const std::string& fn = "", int ln = 0 );
+    UnhandledToken( const char* m, const std::string& fn, int ln );
 
     std::string mMessage;
     std::string mFile;
@@ -54,7 +54,7 @@ public:
 class Unhandled
 {
 public:
-    Unhandled( const std::string& fn = "", int ln = 0 );
+    Unhandled( const std::string& fn, int ln );
 
     std::string mFile;
     int mLineNumber;