diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2022-06-29 10:08:23 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2022-06-29 17:38:47 +0200 |
| commit | 6f064418f5ce5bbc80bedbdf86fb4254369a956e (patch) | |
| tree | 5442312869f46dc2bd505fbd91480f763e599c62 /sc/source/core/data | |
| parent | b43f0b0295953c8d5d16c5b9eccaddb5ec214bab (diff) | |
crashtesting: assert seen on loading forum-de3-8113.ods
This doc is available from https://de.openoffice.info/download/file.php?id=8113
/* TODO: replace by a simple rRecursionHelper.EndIteration() call
* if the assertions hold. */
const bool bOnlyThis = (rRecursionHelper.GetList().size() == 1);
assert(bOnlyThis);
lets assume here that the assertion doesn't hold so drop the TODO
and speculative assert from:
commit ce8a7278e1304f7aaa65bce34aeeda5e83b231f1
Date: Tue Oct 5 20:04:19 2021 +0200
Fix crash if conditional format triggers recursion with iterations enabled
Change-Id: I9030e749b272e2bb0b1ce850e6295a3cd2a11915
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136610
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'sc/source/core/data')
| -rw-r--r-- | sc/source/core/data/formulacell.cxx | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/sc/source/core/data/formulacell.cxx b/sc/source/core/data/formulacell.cxx index 404abe0988cc..e44e0e47a9a9 100644 --- a/sc/source/core/data/formulacell.cxx +++ b/sc/source/core/data/formulacell.cxx @@ -1854,10 +1854,7 @@ bool ScFormulaCell::Interpret(SCROW nStartOffset, SCROW nEndOffset) // It additionally also should mean that the recursion/iteration // ends here as it must had been triggered by this free-flying // out-of-sheets cell - /* TODO: replace by a simple rRecursionHelper.EndIteration() call - * if the assertions hold. */ const bool bOnlyThis = (rRecursionHelper.GetList().size() == 1); - assert(bOnlyThis); rRecursionHelper.GetList().remove_if([this](const ScFormulaRecursionEntry& r){return r.pCell == this;}); if (bOnlyThis) { |