diff options
| author | Eike Rathke <erack@redhat.com> | 2017-07-18 19:43:05 +0200 |
|---|---|---|
| committer | Eike Rathke <erack@redhat.com> | 2017-07-18 19:43:35 +0200 |
| commit | 038063a352f59bad1ecdeeb63016e37f6945a420 (patch) | |
| tree | b64769d58f9bc001dbf235f420038ba436344a33 /sc/source/core/data/global2.cxx | |
| parent | 71c3113e9dbf61693fd947262370cc61cdf31ac7 (diff) | |
Change nonsense non-const Date* GetNullDate() to const Date&
* first, a non-const Date* may leave the impression that one could change the
NullDate through the pointer, which is only partly successful; luckily no one
did that
* second, there is always a NullDate so checking for nullptr is superfluous
* third, the pointer was dereferenced (maybe after a check) everywhere to
obtain the NullDate, luckily..
Change-Id: I3c3a788ba0336596ac6bde4c96e77a0cdb7a4a95
Diffstat (limited to 'sc/source/core/data/global2.cxx')
| -rw-r--r-- | sc/source/core/data/global2.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sc/source/core/data/global2.cxx b/sc/source/core/data/global2.cxx index 1ef86f537b23..ab50f5aae7a4 100644 --- a/sc/source/core/data/global2.cxx +++ b/sc/source/core/data/global2.cxx @@ -590,7 +590,7 @@ Label_fallback_to_unambiguous: else { if (pFormatter) - fValue = aDate - *(pFormatter->GetNullDate()); + fValue = aDate - pFormatter->GetNullDate(); else { SAL_WARN("sc.core","ScGlobal::ConvertStringToValue - fixed null date"); |