Revert "loplugin:constfields in sc"

This reverts commit fb1d3b580763a333bbbfe115d09e1b5cd8849675.

Now that we know that making fields has negative side effects
like disabling assignment operator generation.

Change-Id: Ib48334ffbeb2c768896dd8ced6818aa0b9910b0b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90333
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 6 insertions, 6 deletions

diff --git a/sc/inc/dpobject.hxx b/sc/inc/dpobject.hxx
index c17cb53e43c9..e006b1800bf5 100644
--- a/sc/inc/dpobject.hxx
+++ b/sc/inc/dpobject.hxx
@@ -292,7 +292,7 @@ public:
         typedef std::vector<ScRange> RangeIndexType;
         CachesType m_Caches;
         RangeIndexType maRanges;
-        ScDocument* const mpDoc;
+        ScDocument* mpDoc;
     public:
         SheetCaches(ScDocument* pDoc);
         bool hasCache(const ScRange& rRange) const;
@@ -319,7 +319,7 @@ public:
         friend class ScDPCollection;
         typedef ::std::map<OUString, std::unique_ptr<ScDPCache>> CachesType;
         CachesType m_Caches;
-        ScDocument* const mpDoc;
+        ScDocument* mpDoc;
     public:
         NameCaches(ScDocument* pDoc);
         bool hasCache(const OUString& rName) const;
@@ -340,9 +340,9 @@ public:
      */
     struct DBType
     {
-        sal_Int32 const mnSdbType;
-        OUString const maDBName;
-        OUString const maCommand;
+        sal_Int32 mnSdbType;
+        OUString maDBName;
+        OUString maCommand;
         DBType(sal_Int32 nSdbType, const OUString& rDBName, const OUString& rCommand);
 
         struct less
@@ -359,7 +359,7 @@ public:
         friend class ScDPCollection;
         typedef ::std::map<DBType, std::unique_ptr<ScDPCache>, DBType::less> CachesType;
         CachesType m_Caches;
-        ScDocument* const mpDoc;
+        ScDocument* mpDoc;
     public:
         DBCaches(ScDocument* pDoc);
         bool hasCache(sal_Int32 nSdbType, const OUString& rDBName, const OUString& rCommand) const;