diff options
| author | Mike Kaganski <mike.kaganski@collabora.com> | 2018-11-25 16:31:42 +0300 |
|---|---|---|
| committer | Mike Kaganski <mike.kaganski@collabora.com> | 2018-11-25 16:52:30 +0100 |
| commit | c59a5b81e9521a92587e701bcad82bf643b00493 (patch) | |
| tree | b08b97f67c53e6ec1b3cae06cd19ebac2ca15cea /reportdesign | |
| parent | 75299cd119dcb3121540471354d2b33af7f6684d (diff) | |
tdf#120703 PVS: V560 A part of conditional expression is always true/false
Change-Id: I8d98aa7dd77fbd79611b8a4aba77e8c378fd1cae
Reviewed-on: https://gerrit.libreoffice.org/63981
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'reportdesign')
| -rw-r--r-- | reportdesign/source/ui/dlg/GroupsSorting.cxx | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/reportdesign/source/ui/dlg/GroupsSorting.cxx b/reportdesign/source/ui/dlg/GroupsSorting.cxx index a47ae0ea4640..bac0c4dbae50 100644 --- a/reportdesign/source/ui/dlg/GroupsSorting.cxx +++ b/reportdesign/source/ui/dlg/GroupsSorting.cxx @@ -887,8 +887,8 @@ void OGroupsSortingDialog::UpdateData( ) void OGroupsSortingDialog::DisplayData( sal_Int32 _nRow ) { - sal_Int32 nGroupPos = m_pFieldExpression->getGroupPosition(_nRow); - bool bEmpty = nGroupPos == NO_GROUP; + const sal_Int32 nGroupPos = m_pFieldExpression->getGroupPosition(_nRow); + const bool bEmpty = nGroupPos == NO_GROUP; m_pProperties->Enable(!bEmpty); checkButtons(_nRow); @@ -896,7 +896,7 @@ void OGroupsSortingDialog::DisplayData( sal_Int32 _nRow ) if ( m_pCurrentGroupListener.is() ) m_pCurrentGroupListener->dispose(); m_pCurrentGroupListener = nullptr; - if ( !bEmpty && nGroupPos != NO_GROUP ) + if (!bEmpty) { uno::Reference< report::XGroup> xGroup = getGroup(nGroupPos); |