summaryrefslogtreecommitdiff
path: root/offapi/com/sun
diff options
context:
space:
mode:
authorLászló Németh <nemeth@numbertext.org>2022-05-16 16:05:59 +0200
committerLászló Németh <nemeth@numbertext.org>2022-05-17 15:36:00 +0200
commit6af4c1d097dfba897e305a1e57d1e920f36ce264 (patch)
tree4fa6ea18e365cbdda348d81233cfae0da56f870f /offapi/com/sun
parent4a23511cdad3a82f7c628426ede3eb0928a3a325 (diff)
tdf#123877 sc XLSX: don't freeze during saving recoveryHEADmaster
file by asking password re-typing unstoppably. Instead of this, skip recovery file saving, if the document contains password hashes which haven't been supported by the "calc8" filter of the recovery file (which triggered the "Re-type password" dialog). Solved problems: – Asking for passwords during a non-interactive background process. – A single Cancel didn't close the "Re-type password" dialog window, only pressing three times at least (according to the value of RETRY_STORE_ON_MIGHT_FULL_DISC_USEFULL), but waiting for the password for a while could result a frozen "Re-type password" dialog, where only retyping or removing the password(s) were the escape routes. – Re-typing the password required the password (but modifying the original document doesn't require this). – Removing the password resulted in loss of the protection after saving the original XLSX document. Add a UI test to keep the "Re-type password" dialog during Save As. Note: because of the regression reported in tdf#145757, it needs to wait 10 min for saving the recovery file, yet, despite the changed time in Tools->Options->Load/Save->General. Change-Id: Icc6ee4d67048cdf15ab75ef8e2ee8f1709cdd4c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134409 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
Diffstat (limited to 'offapi/com/sun')
0 files changed, 0 insertions, 0 deletions