diff options
author | Noel Grandin <noel@peralex.com> | 2014-11-18 10:01:21 +0200 |
---|---|---|
committer | Noel Grandin <noel@peralex.com> | 2014-11-18 12:44:28 +0200 |
commit | 0063cf285696951e336b9cec1da8881997b286ce (patch) | |
tree | be70dfd8127c35f9e4a6d18d4db459a587813bf4 /odk/examples/DevelopersGuide/Spreadsheet | |
parent | 250391009aec9930abcc57930ddd4b6f56f4df9c (diff) |
java: make fields final where possible
found by PMD
Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec
Diffstat (limited to 'odk/examples/DevelopersGuide/Spreadsheet')
-rw-r--r-- | odk/examples/DevelopersGuide/Spreadsheet/ExampleAddIn.java | 6 | ||||
-rw-r--r-- | odk/examples/DevelopersGuide/Spreadsheet/ExampleDataPilotSource.java | 30 |
2 files changed, 18 insertions, 18 deletions
diff --git a/odk/examples/DevelopersGuide/Spreadsheet/ExampleAddIn.java b/odk/examples/DevelopersGuide/Spreadsheet/ExampleAddIn.java index c30115770325..a3a2e0975204 100644 --- a/odk/examples/DevelopersGuide/Spreadsheet/ExampleAddIn.java +++ b/odk/examples/DevelopersGuide/Spreadsheet/ExampleAddIn.java @@ -36,9 +36,9 @@ import com.sun.star.sheet.XResultListener; class ExampleAddInResult implements com.sun.star.sheet.XVolatileResult { - private String aName; + private final String aName; private int nValue; - private java.util.ArrayList<XResultListener> aListeners = new java.util.ArrayList<XResultListener>(); + private final java.util.ArrayList<XResultListener> aListeners = new java.util.ArrayList<XResultListener>(); public ExampleAddInResult( String aNewName ) { @@ -79,7 +79,7 @@ class ExampleAddInResult implements com.sun.star.sheet.XVolatileResult class ExampleAddInThread extends Thread { - private java.util.HashMap<String, ExampleAddInResult> aCounters; + private final java.util.HashMap<String, ExampleAddInResult> aCounters; public ExampleAddInThread( java.util.HashMap<String, ExampleAddInResult> aResults ) { diff --git a/odk/examples/DevelopersGuide/Spreadsheet/ExampleDataPilotSource.java b/odk/examples/DevelopersGuide/Spreadsheet/ExampleDataPilotSource.java index 593e8e572f48..445b75da053e 100644 --- a/odk/examples/DevelopersGuide/Spreadsheet/ExampleDataPilotSource.java +++ b/odk/examples/DevelopersGuide/Spreadsheet/ExampleDataPilotSource.java @@ -60,7 +60,7 @@ class ExampleSettings class ExamplePropertySetInfo implements com.sun.star.beans.XPropertySetInfo { - private com.sun.star.beans.Property[] aProperties; + private final com.sun.star.beans.Property[] aProperties; public ExamplePropertySetInfo( com.sun.star.beans.Property[] aProps ) { @@ -95,7 +95,7 @@ class ExamplePropertySetInfo implements com.sun.star.beans.XPropertySetInfo class ExampleMember implements com.sun.star.container.XNamed, com.sun.star.beans.XPropertySet { - private int nMember; + private final int nMember; public ExampleMember( int nMbr ) { @@ -171,7 +171,7 @@ class ExampleMember implements com.sun.star.container.XNamed, class ExampleMembers implements com.sun.star.container.XNameAccess { - private ExampleSettings aSettings; + private final ExampleSettings aSettings; private ExampleMember[] aMembers; public ExampleMembers( ExampleSettings aSet ) @@ -233,8 +233,8 @@ class ExampleLevel implements com.sun.star.sheet.XDataPilotMemberResults, com.sun.star.beans.XPropertySet { - private ExampleSettings aSettings; - private int nDimension; + private final ExampleSettings aSettings; + private final int nDimension; private ExampleMembers aMembers; public ExampleLevel( ExampleSettings aSet, int nDim ) @@ -379,8 +379,8 @@ class ExampleLevel implements class ExampleLevels implements com.sun.star.container.XNameAccess { - private ExampleSettings aSettings; - private int nDimension; + private final ExampleSettings aSettings; + private final int nDimension; private ExampleLevel aLevel; public ExampleLevels( ExampleSettings aSet, int nDim ) @@ -432,8 +432,8 @@ class ExampleLevels implements com.sun.star.container.XNameAccess class ExampleHierarchy implements com.sun.star.container.XNamed, com.sun.star.sheet.XLevelsSupplier { - private ExampleSettings aSettings; - private int nDimension; + private final ExampleSettings aSettings; + private final int nDimension; private ExampleLevels aLevels; public ExampleHierarchy( ExampleSettings aSet, int nDim ) @@ -468,8 +468,8 @@ class ExampleHierarchy implements com.sun.star.container.XNamed, class ExampleHierarchies implements com.sun.star.container.XNameAccess { - private ExampleSettings aSettings; - private int nDimension; + private final ExampleSettings aSettings; + private final int nDimension; private ExampleHierarchy aHierarchy; public ExampleHierarchies( ExampleSettings aSet, int nDim ) @@ -524,8 +524,8 @@ class ExampleDimension implements com.sun.star.util.XCloneable, com.sun.star.beans.XPropertySet { - private ExampleSettings aSettings; - private int nDimension; + private final ExampleSettings aSettings; + private final int nDimension; private ExampleHierarchies aHierarchies; private com.sun.star.sheet.DataPilotFieldOrientation eOrientation; @@ -694,7 +694,7 @@ class ExampleDimension implements class ExampleDimensions implements com.sun.star.container.XNameAccess { - private ExampleSettings aSettings; + private final ExampleSettings aSettings; private ExampleDimension[] aDimensions; public ExampleDimensions( ExampleSettings aSet ) @@ -763,7 +763,7 @@ public class ExampleDataPilotSource static private final String aServiceName = "com.sun.star.sheet.DataPilotSource"; static private final String aImplName = _ExampleDataPilotSource.class.getName(); - private ExampleSettings aSettings = new ExampleSettings(); + private final ExampleSettings aSettings = new ExampleSettings(); private ExampleDimensions aDimensions; public _ExampleDataPilotSource( com.sun.star.lang.XMultiServiceFactory xFactory ) |