summaryrefslogtreecommitdiff
path: root/o3tl
diff options
context:
space:
mode:
authorTor Lillqvist <tml@collabora.com>2018-05-16 20:14:39 +0300
committerTor Lillqvist <tml@collabora.com>2018-05-18 09:51:59 +0200
commit16f784b10695d1d3212463f96f597c665a90a8e2 (patch)
tree843926de0b6068b2947f6c12913f3fd2e6a6b44f /o3tl
parentfd1bc178b02e05cd12ec784ff87f5c97069bc5f5 (diff)
tdf#116511: Drop questionable check for more keyboard input
For some reason, on macOS, when this is being invoked through the shortcut, Application::AnyInput( VclInputFlags::KEYBOARD ) returns true, so the code thinks that there is more keyboard input and won't call UpdateTokenArray(), which sets m_pTokenArray. I think that optmisation is questionable, especially as the exact semantics of our event loop API, like Application::AnyInput(), is under-defined and probably can and will change in various minor ways when people work on improving it on the Mac (and perhaps other platforms, too). (The event loop etc certainly needs improvement on the Mac. Consider the "WindowServer grows to tens of gigabytes when running make check" issue which is closely related. Unfortunately nobody has come up with a simple fix for that yet, exactly because we use our event loop related APIs in so imaginative ways all over the code, and fixing one thing usually breaks another.) Change-Id: I865d46e5ee69609ad58bc915ff949e0f3602d8f5 Reviewed-on: https://gerrit.libreoffice.org/54448 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
Diffstat (limited to 'o3tl')
0 files changed, 0 insertions, 0 deletions