summaryrefslogtreecommitdiff
path: root/logerrit
diff options
context:
space:
mode:
authorBjoern Michaelsen <bjoern.michaelsen@canonical.com>2012-07-05 12:41:59 +0200
committerMiklos Vajna <vmiklos@suse.cz>2012-07-05 13:15:34 +0200
commitf3b1a1581324085257f3eb8290a086b22dcca8f5 (patch)
tree7dd10d65d54f937bab85a7f070c21b630195a8c7 /logerrit
parentb103aeb9de34ae790e6055ba49adcc9b679d7516 (diff)
fix ./logerrit review
* ./logerrit review did not resolve the ChangeId to a SHA * ./logerrit did still echo the command instead of executing it. Change-Id: Ie4f8630f7a83134d6eb7992f4a61b5d3faf7e138
Diffstat (limited to 'logerrit')
-rwxr-xr-xlogerrit3
1 files changed, 2 insertions, 1 deletions
diff --git a/logerrit b/logerrit
index 851af7de1f32..cc24c767e76a 100755
--- a/logerrit
+++ b/logerrit
@@ -159,7 +159,8 @@ case "$1" in
;;
esac
read -p "please type a friendly comment$MESSAGEREQ: " MESSAGE
- echo ssh ${GERRITHOST?} gerrit review -m '\"'$MESSAGE'\"' $VERIFIEDFLAG $CODEREVIEWFLAG $CHANGEID
+ get_SHA_for_change $CHANGEID
+ ssh ${GERRITHOST?} gerrit review -m \"$MESSAGE\" $VERIFIEDFLAG $CODEREVIEWFLAG $SHA
;;
checkout)
get_SHA_for_change $2