From f3b1a1581324085257f3eb8290a086b22dcca8f5 Mon Sep 17 00:00:00 2001
From: Bjoern Michaelsen <bjoern.michaelsen@canonical.com>
Date: Thu, 5 Jul 2012 12:41:59 +0200
Subject: fix ./logerrit review

 * ./logerrit review did not resolve the ChangeId to a SHA
 * ./logerrit did still echo the command instead of executing it.

Change-Id: Ie4f8630f7a83134d6eb7992f4a61b5d3faf7e138
---
 logerrit | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

(limited to 'logerrit')

diff --git a/logerrit b/logerrit
index 851af7de1f32..cc24c767e76a 100755
--- a/logerrit
+++ b/logerrit
@@ -159,7 +159,8 @@ case "$1" in
 			;;
 		esac
 		read -p "please type a friendly comment$MESSAGEREQ: " MESSAGE
-		echo ssh ${GERRITHOST?} gerrit review -m '\"'$MESSAGE'\"' $VERIFIEDFLAG $CODEREVIEWFLAG $CHANGEID
+		get_SHA_for_change $CHANGEID
+		ssh ${GERRITHOST?} gerrit review -m \"$MESSAGE\" $VERIFIEDFLAG $CODEREVIEWFLAG $SHA
 	;;
 	checkout)
 		get_SHA_for_change $2
-- 
cgit v1.2.3