diff options
author | Bjoern Michaelsen <bjoern.michaelsen@canonical.com> | 2012-07-05 12:41:59 +0200 |
---|---|---|
committer | Miklos Vajna <vmiklos@suse.cz> | 2012-07-05 13:15:34 +0200 |
commit | f3b1a1581324085257f3eb8290a086b22dcca8f5 (patch) | |
tree | 7dd10d65d54f937bab85a7f070c21b630195a8c7 /logerrit | |
parent | b103aeb9de34ae790e6055ba49adcc9b679d7516 (diff) |
fix ./logerrit review
* ./logerrit review did not resolve the ChangeId to a SHA
* ./logerrit did still echo the command instead of executing it.
Change-Id: Ie4f8630f7a83134d6eb7992f4a61b5d3faf7e138
Diffstat (limited to 'logerrit')
-rwxr-xr-x | logerrit | 3 |
1 files changed, 2 insertions, 1 deletions
@@ -159,7 +159,8 @@ case "$1" in ;; esac read -p "please type a friendly comment$MESSAGEREQ: " MESSAGE - echo ssh ${GERRITHOST?} gerrit review -m '\"'$MESSAGE'\"' $VERIFIEDFLAG $CODEREVIEWFLAG $CHANGEID + get_SHA_for_change $CHANGEID + ssh ${GERRITHOST?} gerrit review -m \"$MESSAGE\" $VERIFIEDFLAG $CODEREVIEWFLAG $SHA ;; checkout) get_SHA_for_change $2 |