Removed some unused parameters; added SAL_UNUSED_PARAMETER.

SAL_UNUSED_PARAMETER (expanding to __attribute__ ((unused)) for GCC)
is used to annotate legitimately unused parameters, so that static
analysis tools can tell legitimately unused parameters from truly
unnecessary ones.  To that end, some patches for external modules
are also added, that are only applied when compiling with GCC and
add necessary __attribute__ ((unused)) in headers.

6 files changed, 22 insertions, 9 deletions

diff --git a/io/source/TextInputStream/TextInputStream.cxx b/io/source/TextInputStream/TextInputStream.cxx
index cab6ea8d64a2..5bf76c5be30f 100644
--- a/io/source/TextInputStream/TextInputStream.cxx
+++ b/io/source/TextInputStream/TextInputStream.cxx
@@ -443,7 +443,8 @@ Reference< XInputStream > OTextInputStream::getInputStream()
 }
 
 
-Reference< XInterface > SAL_CALL TextInputStream_CreateInstance( const Reference< XComponentContext > &)
+Reference< XInterface > SAL_CALL TextInputStream_CreateInstance(
+    SAL_UNUSED_PARAMETER const Reference< XComponentContext > &)
 {
     return Reference < XInterface >( ( OWeakObject * ) new OTextInputStream() );
 }
diff --git a/io/source/TextOutputStream/TextOutputStream.cxx b/io/source/TextOutputStream/TextOutputStream.cxx
index 38cbf46a3604..90f34ab22b7f 100644
--- a/io/source/TextOutputStream/TextOutputStream.cxx
+++ b/io/source/TextOutputStream/TextOutputStream.cxx
@@ -238,7 +238,8 @@ Reference< XOutputStream > OTextOutputStream::getOutputStream()
 }
 
 
-Reference< XInterface > SAL_CALL TextOutputStream_CreateInstance( const Reference< XComponentContext > &)
+Reference< XInterface > SAL_CALL TextOutputStream_CreateInstance(
+    SAL_UNUSED_PARAMETER const Reference< XComponentContext > &)
 {
     return Reference < XInterface >( ( OWeakObject * ) new OTextOutputStream() );
 }
diff --git a/io/source/stm/odata.cxx b/io/source/stm/odata.cxx
index 95fea956718c..bb305b8ac692 100644
--- a/io/source/stm/odata.cxx
+++ b/io/source/stm/odata.cxx
@@ -500,7 +500,9 @@ Sequence< OUString > ODataInputStream::getSupportedServiceNames(void) throw ()
 *
 ****/
 
-Reference< XInterface > SAL_CALL ODataInputStream_CreateInstance( const Reference < XComponentContext > & ) throw( Exception)
+Reference< XInterface > SAL_CALL ODataInputStream_CreateInstance(
+    SAL_UNUSED_PARAMETER const Reference < XComponentContext > & )
+    throw( Exception)
 {
     ODataInputStream *p = new ODataInputStream;
     return Reference< XInterface > ( (OWeakObject * ) p );
@@ -904,7 +906,9 @@ Sequence< OUString > ODataOutputStream::getSupportedServiceNames(void) throw ()
 
 
 
-Reference< XInterface > SAL_CALL ODataOutputStream_CreateInstance( const Reference < XComponentContext > & ) throw(Exception)
+Reference< XInterface > SAL_CALL ODataOutputStream_CreateInstance(
+    SAL_UNUSED_PARAMETER const Reference < XComponentContext > & )
+    throw(Exception)
 {
     ODataOutputStream *p = new ODataOutputStream;
     Reference< XInterface > xService = *p;
@@ -1186,7 +1190,8 @@ sal_Int32 OObjectOutputStream::offsetToMark(sal_Int32 nMark)
 
 
 
-Reference< XInterface > SAL_CALL OObjectOutputStream_CreateInstance( const Reference < XComponentContext > & )
+Reference< XInterface > SAL_CALL OObjectOutputStream_CreateInstance(
+    SAL_UNUSED_PARAMETER const Reference < XComponentContext > & )
     throw(Exception)
 {
     OObjectOutputStream *p = new OObjectOutputStream;
diff --git a/io/source/stm/omark.cxx b/io/source/stm/omark.cxx
index 85a0cc9ce5d7..49fa8e20e0b6 100644
--- a/io/source/stm/omark.cxx
+++ b/io/source/stm/omark.cxx
@@ -464,7 +464,9 @@ Sequence< OUString > OMarkableOutputStream::getSupportedServiceNames(void) throw
 * external binding
 *
 *------------------------*/
-Reference< XInterface > SAL_CALL OMarkableOutputStream_CreateInstance( const Reference < XComponentContext > & ) throw(Exception)
+Reference< XInterface > SAL_CALL OMarkableOutputStream_CreateInstance(
+    SAL_UNUSED_PARAMETER const Reference < XComponentContext > & )
+    throw(Exception)
 {
     OMarkableOutputStream *p = new OMarkableOutputStream( );
 
@@ -991,7 +993,8 @@ Sequence< OUString > OMarkableInputStream::getSupportedServiceNames(void) throw
 *
 *------------------------*/
 Reference < XInterface > SAL_CALL OMarkableInputStream_CreateInstance(
-    const Reference < XComponentContext > & ) throw(Exception)
+    SAL_UNUSED_PARAMETER const Reference < XComponentContext > & )
+    throw(Exception)
 {
     OMarkableInputStream *p = new OMarkableInputStream( );
     return Reference< XInterface > ( (OWeakObject * ) p );
diff --git a/io/source/stm/opipe.cxx b/io/source/stm/opipe.cxx
index aa2f3abbeba2..9de67a94537b 100644
--- a/io/source/stm/opipe.cxx
+++ b/io/source/stm/opipe.cxx
@@ -454,7 +454,8 @@ Sequence< OUString > OPipeImpl::getSupportedServiceNames(void) throw(  )
 
 
 Reference < XInterface > SAL_CALL OPipeImpl_CreateInstance(
-    const Reference < XComponentContext > & ) throw(Exception)
+    SAL_UNUSED_PARAMETER const Reference < XComponentContext > & )
+    throw(Exception)
 {
     OPipeImpl *p = new OPipeImpl;
 
diff --git a/io/source/stm/opump.cxx b/io/source/stm/opump.cxx
index 409fe59869a4..607dda727890 100644
--- a/io/source/stm/opump.cxx
+++ b/io/source/stm/opump.cxx
@@ -485,7 +485,9 @@ Sequence< OUString > Pump::getSupportedServiceNames(void) throw(  )
 }
 
 
-Reference< XInterface > SAL_CALL OPumpImpl_CreateInstance( const Reference< XComponentContext > & ) throw (Exception)
+Reference< XInterface > SAL_CALL OPumpImpl_CreateInstance(
+    SAL_UNUSED_PARAMETER const Reference< XComponentContext > & )
+    throw (Exception)
 {
     return Reference< XInterface >( *new Pump );
 }