new loplugin:conststringfield

Look for const string fields which can be static, and
mostly convert them to OUStringLiteral

And add a getLength() method to OUStringLiteral to make
the transition easier.

Remove dead code in XclExpRoot::GenerateDefaultEncryptionData,
default password is never empty.

Change-Id: Iae75514d9dbb87289fd5b016222f640abe755091
Reviewed-on: https://gerrit.libreoffice.org/59204
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 20 insertions, 75 deletions

diff --git a/include/xmloff/txtparae.hxx b/include/xmloff/txtparae.hxx
index 6a09abdaf30f..f19080d0c518 100644
--- a/include/xmloff/txtparae.hxx
+++ b/include/xmloff/txtparae.hxx
@@ -132,83 +132,28 @@ public:
 private:
 
     // Implement Title/Description Elements UI (#i73249#)
-    const OUString sTitle;
-    const OUString sDescription;
-    const OUString sAnchorCharStyleName;
-    const OUString sAnchorPageNo;
-    const OUString sAnchorType;
-    const OUString sBeginNotice;
-    const OUString sBookmark;
-    const OUString sCategory;
-    const OUString sChainNextName;
-    const OUString sCharStyleName;
-    const OUString sCharStyleNames;
-    const OUString sContourPolyPolygon;
-    const OUString sDocumentIndexMark;
-    const OUString sEndNotice;
-    const OUString sFootnote;
-    const OUString sFootnoteCounting;
-    const OUString sFrame;
-    const OUString sGraphicFilter;
-    const OUString sGraphicRotation;
-    const OUString sHeight;
-    const OUString sHoriOrient;
-    const OUString sHoriOrientPosition;
-    const OUString sHyperLinkName;
-    const OUString sHyperLinkTarget;
-    const OUString sHyperLinkURL;
-    const OUString sIsAutomaticContour;
-    const OUString sIsCollapsed;
-    const OUString sIsPixelContour;
-    const OUString sIsStart;
-    const OUString sIsSyncHeightToWidth;
-    const OUString sIsSyncWidthToHeight;
-    const OUString sNumberingRules;
-    const OUString sNumberingType;
-    const OUString sPageDescName;
-    const OUString sPageStyleName;
-    const OUString sParaConditionalStyleName;
-    const OUString sParagraphService;
-    const OUString sParaStyleName;
-    const OUString sPositionEndOfDoc;
-    const OUString sPrefix;
-    const OUString sRedline;
-    const OUString sReferenceId;
-    const OUString sReferenceMark;
-    const OUString sRelativeHeight;
-    const OUString sRelativeWidth;
-    const OUString sRuby;
-    const OUString sRubyCharStyleName;
-    const OUString sRubyText;
-    const OUString sServerMap;
-    const OUString sShapeService;
-    const OUString sSizeType;
-    const OUString sSoftPageBreak;
-    const OUString sStartAt;
-    const OUString sSuffix;
-    const OUString sTableService;
-    const OUString sText;
-    const OUString sTextContentService;
-    const OUString sTextEmbeddedService;
-    const OUString sTextEndnoteService;
-    const OUString sTextField;
-    const OUString sTextFieldService;
-    const OUString sTextFrameService;
-    const OUString sTextGraphicService;
-    const OUString sTextPortionType;
-    const OUString sTextSection;
-    const OUString sUnvisitedCharStyleName;
-    const OUString sVertOrient;
-    const OUString sVertOrientPosition;
-    const OUString sVisitedCharStyleName;
-    const OUString sWidth;
-    const OUString sWidthType;
-    const OUString sTextFieldStart;
-    const OUString sTextFieldEnd;
-    const OUString sTextFieldStartEnd;
+    static const OUStringLiteral gsAnchorCharStyleName;
+    static const OUStringLiteral gsBeginNotice;
+    static const OUStringLiteral gsCategory;
+    static const OUStringLiteral gsCharStyleName;
+    static const OUStringLiteral gsCharStyleNames;
+    static const OUStringLiteral gsEndNotice;
+    static const OUStringLiteral gsFootnote;
+    static const OUStringLiteral gsFootnoteCounting;
+    static const OUStringLiteral gsNumberingType;
+    static const OUStringLiteral gsPageDescName;
+    static const OUStringLiteral gsPageStyleName;
+    static const OUStringLiteral gsParaStyleName;
+    static const OUStringLiteral gsPositionEndOfDoc;
+    static const OUStringLiteral gsPrefix;
+    static const OUStringLiteral gsReferenceId;
+    static const OUStringLiteral gsStartAt;
+    static const OUStringLiteral gsSuffix;
+    static const OUStringLiteral gsTextEndnoteService;
+    static const OUStringLiteral gsTextSection;
 
 protected:
-    const OUString sFrameStyleName;
+    static const OUStringLiteral gsFrameStyleName;
     SinglePropertySetInfoCache aCharStyleNamesPropInfoCache;
 
     SvXMLAutoStylePoolP& GetAutoStylePool() { return rAutoStylePool; }