diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2016-01-12 14:44:42 +0100 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2016-01-12 14:44:42 +0100 |
| commit | 548c43238d02b34cf73e7c2ca1a912ee4fe82544 (patch) | |
| tree | d049fa84ccc44e949f86c71f9e31a997719813cd /include/svl | |
| parent | 791ad3e170bcb5a2daedac77932dc9822f7f1092 (diff) | |
Mark some classes as final
...namely exactly those for which fa91dd31f39a24329d288d4e1cda28db3a16af0d
"5th step to remove tools/rtti.hxx" (which is assumed the culprit in tdf#96067
"Crash on undo row inserts") had replaced exact-type checks of the form
v->Type() == TYPE(X)
with type-or-subtype-of checks of the form
dynamic_cast<X *>(v) != nullptr
which is only sound if X is a final class. (Except for one case already handled
differently in 791ad3e170bcb5a2daedac77932dc9822f7f1092 "Stick to exact-type
check.")
Change-Id: Ia822c55c7c0e982d42c6a97589307e577721e324
Diffstat (limited to 'include/svl')
| -rw-r--r-- | include/svl/poolitem.hxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/svl/poolitem.hxx b/include/svl/poolitem.hxx index 6f143bb88f88..0ae6bea2c512 100644 --- a/include/svl/poolitem.hxx +++ b/include/svl/poolitem.hxx @@ -247,7 +247,7 @@ inline bool IsInvalidItem(const SfxPoolItem *pItem) return pItem == reinterpret_cast<SfxPoolItem *>(-1); } -class SVL_DLLPUBLIC SfxVoidItem: public SfxPoolItem +class SVL_DLLPUBLIC SfxVoidItem final: public SfxPoolItem { SfxVoidItem & operator=( const SfxVoidItem& ) = delete; public: |