perf: eliminate SfxSimpleHint and move to SfxHint, tdf#87101 related

There were over 150 places in *::Notify() functions that did some
dynamic_cast<SfxSimpleHint*> of which ~98% were unnecessary because the
base class SfxHint passed was an SfxSimpleHint anyway. dynamic_cast
operations come with quite some cost, so avoid if possible. Specifically
for ScFormulaCell::Notify() that created a bottleneck in scenarios where
cells were notified that already handled a previous notification. In
mass operations doing the dynamic_cast before it could be decided
whether having to act on it or not this made 2/3 of all time spent in
the Notify() call.

To get rid of that rename/move SfxSimpleHint to SfxHint and let classes
derive from SfxHint instead of SfxSimpleHint. This comes only with a
slight cost that an additional sal_uInt32 is transported in such hints,
initialized to 0, but this is neglectable compared to the huge gain.

For the rare cases where a Notify() actually expects both, an SfxHint
(formerly SfxSimpleHint) and a derived hint, this changed order of the
dynamic_cast involved so the simple SfxHint::GetId() is handled last.
Modules using such combinations can further optimize by treating the
simple SfxHint::GetId() first once verified that none of the other
derived hints use an ID not equal to zero respectively none of the ID
values the simple hint uses.

Change-Id: I9fcf723e3a4487ceb92336189d23a62c344cf0ce
Reviewed-on: https://gerrit.libreoffice.org/29205
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Eike Rathke <erack@redhat.com>

1 files changed, 29 insertions, 1 deletions

diff --git a/include/svl/hint.hxx b/include/svl/hint.hxx
index 4aec70090c54..8de965d73af5 100644
--- a/include/svl/hint.hxx
+++ b/include/svl/hint.hxx
@@ -19,15 +19,43 @@
 #ifndef INCLUDED_SVL_HINT_HXX
 #define INCLUDED_SVL_HINT_HXX
 
+#include <sal/types.h>
 #include <svl/svldllapi.h>
 
+#define SFX_HINT_DYING              0x00000001
+#define SFX_HINT_NAMECHANGED        0x00000002
+#define SFX_HINT_TITLECHANGED       0x00000004
+#define SFX_HINT_DATACHANGED        0x00000008
+#define SFX_HINT_DOCCHANGED         0x00000010
+#define SFX_HINT_UPDATEDONE         0x00000020
+#define SFX_HINT_DEINITIALIZING     0x00000040
+#define SFX_HINT_MODECHANGED        0x00000080
+    // unused, formerly SFX_HINT_CANCELLABLE
+    // unused, formerly SFX_HINT_DATAAVAILABLE
+    // unused, formerly SFX_HINT_SAVECOMPLETED
+    // unused, formerly SFX_HINT_RELEASEREF
+#define SFX_HINT_COLORS_CHANGED     0x00001000
+#define SFX_HINT_CTL_SETTINGS_CHANGED   0x00002000
+#define SFX_HINT_ACCESSIBILITY_CHANGED  0x00004000
+    // unused, formerly SFX_HINT_VIEWCREATED
+#define SFX_HINT_USER00             0x00010000
+#define SFX_HINT_USER01             0x00020000
+#define SFX_HINT_USER02             0x00040000
+#define SFX_HINT_USER03             0x00080000
+#define SFX_HINT_USER04             0x00100000
+#define SFX_HINT_USER05             0x00200000
+
 class SVL_DLLPUBLIC SfxHint
 {
+private:
+    sal_uInt32 mnId;
 public:
+    SfxHint() : mnId(0) {}
+    explicit SfxHint( sal_uInt32 nId ) : mnId(nId) {}
     virtual ~SfxHint();
+    sal_uInt32 GetId() const { return mnId; }
 };
 
-
 #endif
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */