diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-04-23 09:26:46 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-04-23 14:10:38 +0200 |
| commit | 10c934147d469965dba6abc78efd02759a010b8e (patch) | |
| tree | 54fe37d01913d48abf93bd087c59f95fdcfa5a46 /include/svl/hint.hxx | |
| parent | a08401155a0b4b49878e8e50d39b2fd3e5278779 (diff) | |
tdf#113266 slow opening XLS with 45 MB drawing
Some hot-spots around dynamic_cast of SdrHint, so avoid that by creating
special SfxHintId::ThisIsAnSdrHint
The most common CPU hot-spot was in SvxShape::Notify, the other changes
are just for consistency.
Also remove some dead code in ScShapeChildren, the Notify method was
doing nothing useful.
Change-Id: I696db1fcafc09bb10bf23ac673de292746141491
Reviewed-on: https://gerrit.libreoffice.org/71108
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'include/svl/hint.hxx')
| -rw-r--r-- | include/svl/hint.hxx | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/include/svl/hint.hxx b/include/svl/hint.hxx index 98d0ca81de55..708986e31631 100644 --- a/include/svl/hint.hxx +++ b/include/svl/hint.hxx @@ -112,6 +112,8 @@ enum class SfxHintId { SwDrawViewsCreated, SwSplitNodeOperation, SwSectionFrameMoveAndDelete, + + ThisIsAnSdrHint // used to avoid dynamic_cast }; template< typename charT, typename traits > @@ -190,6 +192,7 @@ inline std::basic_ostream<charT, traits> & operator <<( case SfxHintId::SwDrawViewsCreated: return stream << "SwDrawViewsCreated"; case SfxHintId::SwSplitNodeOperation: return stream << "SwSplitNodeOperation"; case SfxHintId::SwSectionFrameMoveAndDelete: return stream << "SwSectionFrameMoveAndDelete"; + case SfxHintId::ThisIsAnSdrHint: return stream << "SdrHint"; default: return stream << "unk(" << std::to_string(int(id)) << ")"; } } |