pvs-studio: V794 The assignment operator should be protected

Change-Id: Ia443a0e61a091d877c8da26bf7d45bf4261f8669
Reviewed-on: https://gerrit.libreoffice.org/62166
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

1 files changed, 11 insertions, 9 deletions

diff --git a/include/canvas/vclwrapper.hxx b/include/canvas/vclwrapper.hxx
index 77cf8b705e11..0a80cb282986 100644
--- a/include/canvas/vclwrapper.hxx
+++ b/include/canvas/vclwrapper.hxx
@@ -95,17 +95,19 @@ namespace canvas
             // assignment to wrappee
             VCLObject& operator=( const VCLObject& rhs )
             {
-                if( mpWrappee )
+                if (this != &rhs)
                 {
-                    if( rhs.mpWrappee )
-                        *mpWrappee = *rhs.mpWrappee;
+                    if( mpWrappee )
+                    {
+                        if( rhs.mpWrappee )
+                            *mpWrappee = *rhs.mpWrappee;
+                    }
+                    else
+                    {
+                        if( rhs.mpWrappee )
+                            mpWrappee = new Wrappee( *rhs.mpWrappee );
+                    }
                 }
-                else
-                {
-                    if( rhs.mpWrappee )
-                        mpWrappee = new Wrappee( *rhs.mpWrappee );
-                }
-
                 return *this;
             }