Convert indexOf->startsWith and lastIndexOf->endsWith

This is both an optimisation and a cleanup.

This converts code like
   aStr.indexOf("XX") == 0
to
  aStr.startsWith("XX")
and converts code like
  aStr.lastIndexOf("XXX") == aStr.getLength() - 3
to
  aStr.endsWith("XXX")

Note that in general
  aStr.lastIndexOf("X") == aStr.getLength() - 1
converts to
  aStr.isEmpty() || aStr.endsWith("X")
so I used the surrounding context to determine if aStr could be empty
when modifying the code.

Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669

2 files changed, 3 insertions, 7 deletions

diff --git a/idlc/source/astscope.cxx b/idlc/source/astscope.cxx
index 1c0d4fd84101..ba06611feb1a 100644
--- a/idlc/source/astscope.cxx
+++ b/idlc/source/astscope.cxx
@@ -25,13 +25,9 @@
 
 using namespace ::rtl;
 
-sal_Bool isGlobal(const OString& scopedName)
+bool isGlobal(const OString& scopedName)
 {
-    if (scopedName.isEmpty() || (scopedName.indexOf(':') == 0))
-    {
-        return sal_True;
-    }
-    return sal_False;
+    return scopedName.isEmpty() || scopedName.startsWith(":");
 }
 
 AstScope::AstScope(NodeType nodeType)
diff --git a/idlc/source/idlccompile.cxx b/idlc/source/idlccompile.cxx
index 8a98af2aa456..8c6701aa292a 100644
--- a/idlc/source/idlccompile.cxx
+++ b/idlc/source/idlccompile.cxx
@@ -60,7 +60,7 @@ static sal_Char tmpFilePattern[512];
 
 sal_Bool isFileUrl(const OString& fileName)
 {
-    if (fileName.indexOf("file://") == 0 )
+    if (fileName.startsWith("file://") )
         return sal_True;
     return sal_False;
 }