tdf#169462: Fix notebookbar separators in qt

The ControlType::Fixedline is rendered only (afaics) in
vcl/source/control/(button.cxx|fixed.cxx).
In button.cxx it is used as a horizontal separator for the
potential dropdown button. In fixed.cxx it is used as a generic
separator. FixedLine is used
a) for occurrences of `GtkSeparator` when building *.ui files
   (see vcl/source/window/builder.cxx:1699), which is extensively
   in notebookbar*.ui, and
b) for tab dialogs (see vcl/source/window/tabdlg.cxx:146, it's
   unclear to me what exactly is done here).

For ControlType::Fixedline, we now use a Qt toolbar separator instead of a
Qt menu item separator, since the latter works only for horizontal separators,
at least in the Breeze theme, see the following LOCs at breeze, where
`renderSeparator` is called with `vertical` always defaulting to false:
https://github.com/KDE/breeze/blob/b7239b664a640378a8dcc609fc8f09a11a5d7c35/kstyle/breezestyle.cpp#L6008
https://github.com/KDE/breeze/blob/b7239b664a640378a8dcc609fc8f09a11a5d7c35/kstyle/breezehelper.h#L236
This resulted in separators that only consisted of a single dot.

As far as I can see on Breeze, the difference for horizontal separators between
toolbar and menu item separators is that menu item separators have a slight
horizontal margin. Usually (imo) this margin is not wanted anyways when GtkSeparator
is used.

Change-Id: I7b83ebf45fde2db4eac15aaec0c556e7b8c2e89d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/203696
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>

0 files changed, 0 insertions, 0 deletions