diff options
| author | Eike Rathke <erack@redhat.com> | 2022-09-28 20:51:05 +0200 |
|---|---|---|
| committer | Eike Rathke <erack@redhat.com> | 2022-09-29 00:42:12 +0200 |
| commit | 48b9cbc742de3f6120986cb6cafc92eb5009da82 (patch) | |
| tree | 06edc4727074bb42db292e40d1582dae447542e3 /icon-themes/sifr_dark/cmd/lc_viewdatasourcebrowser.png | |
| parent | 1f7b050d83966b51e0b22de9b565bf4ceacdad16 (diff) | |
Fix incrementing number in dbrange names during copying, tdf#145054 follow-up
lcl_IncrementNumberInNamedRange() during copying a sheet didn't do
what it was supposed to do, it could generate names that would had
been cell references, and the loop it was called from could had
prematurely ended because it inserted into the set it was
iterating over; also the loop ended as soon as it encountered just
one dbrange that wasn't on the sheet that was copied. That never
worked as intended with more than just a very few names only on
the same sheet.
Additionally after the actual change loplugin:stringviewparam
forced me to pass a std::u16string_view parameter, for that some
adaptions had to be made.
Change-Id: Ib83d317c69d821e8e8a2f1cd6791da9616ed188d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140717
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
Diffstat (limited to 'icon-themes/sifr_dark/cmd/lc_viewdatasourcebrowser.png')
0 files changed, 0 insertions, 0 deletions
