diff options
| author | Michael Weghorn <m.weghorn@posteo.de> | 2026-03-17 14:57:01 +0100 |
|---|---|---|
| committer | Michael Weghorn <m.weghorn@posteo.de> | 2026-03-18 17:41:39 +0100 |
| commit | 793a077ec204031ce6742e653320a25ea692d503 (patch) | |
| tree | 86d86a79c735c98580e9c55c4667ef8fe3fa2b69 /icon-themes/colibre_svg/cmd/32/insertcellsright.svg | |
| parent | b2e321ca29d1976c9c20c91bffd83db36e3c042c (diff) | |
cui: Drop assert that triggers for gtk3 in WidgetTestDialog::FillTreeView
This assert was introduced in
commit 2e0381693bce6a2ed16e72984edcb587174939fb
Date: Fri Jul 4 08:11:19 2025 +0000
Fix out-of-bound crash in test dialog 2
, but triggers for gtk3:
soffice.bin: .../cui/source/dialogs/widgettestdlg.cxx:82: void WidgetTestDialog::FillTreeView(): Assertion `nWidth > 0 && "suspicious to get a value like this"' failed.
Remove it for now to make the dialog work again with gtk3.
Possibly the method only returns a useful value after layout
has happened for gtk3 - see also this commint in
GtkInstanceTreeView::get_column_width:
virtual int get_column_width(int nColumn) const override
{
GtkTreeViewColumn* pColumn = GTK_TREE_VIEW_COLUMN(g_list_nth_data(m_pColumns, nColumn));
assert(pColumn && "wrong count");
int nWidth = gtk_tree_view_column_get_width(pColumn);
// https://github.com/exaile/exaile/issues/580
// after setting fixed_width on a column and requesting width before
// gtk has a chance to do its layout of the column means that the width
// request hasn't come into effect
if (!nWidth)
nWidth = gtk_tree_view_column_get_fixed_width(pColumn);
return nWidth;
}
To trigger the dialog:
* in "Tools" -> "Customize", set a keyboard shortcut for
function/UNO command ".uno:WidgetTestDialog"
* close the dialog and activat the shortcut
Change-Id: I0e2c25636acad995bdd0b5c225c48079a13fcc89
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/201938
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Diffstat (limited to 'icon-themes/colibre_svg/cmd/32/insertcellsright.svg')
0 files changed, 0 insertions, 0 deletions
