summaryrefslogtreecommitdiff
path: root/filter
diff options
context:
space:
mode:
authorJan-Marek Glogowski <glogow@fbihome.de>2020-12-29 11:42:30 +0100
committerJan-Marek Glogowski <glogow@fbihome.de>2021-12-01 18:37:23 +0100
commited583bf8d553b145f83b66118253aaf7ac94fa1a (patch)
treee63a852a9f57505ad564e07ec4baf46d3d1307b0 /filter
parentb9c106d491d2c13d74760a47e424192a3291860a (diff)
gbuild: introduce plugin + loader concepts
This introduces two concepts: a plugin and its loader (library) LO currrently has dependency cycles for some libraries. There is scui, which depends on sc, while sc dlopen's scui. There are the various vclplug_*, i18npool plugins, filters/gie, acc, etc. Usually these plugins link to their loader library, because they use its symbols. But as a result there is no sensible way to express the runtime dependency of loaders on the plugins. In GNU libtool plugins are called modules and they are implemented in an IMHO more sensible way by allowing missing symbols at link time. This way you can have a dependency from the loader library to its plugins, as the plugins don't depend on the loader, but you lose the link time detection of missing symbols. While this is in theory possible in LO too, LO currently has plugins, like acc (accessibility), loaded by tk (toolkit), which depends on svt (svtools), which itself depends on tk, so dropping the tk dependency for acc on its own doesn't help :-( And while the dependency of the plugins on their loader is fine for the shared / DYNLOADING build, for the "static" builds you must (somehow) link the plugins into the executables. I also codeified a few rules into the build system along with it: * just plugins are allowed to depend / link other plugins * plugins aren't allowed to be linked into the merge lib * plugin loaders are "limited" to libraries At the high level, this is implemented via new gbuild calls: * gb_Library_set_plugin_for,lib,loader: declare a library to be a plugin of a loader library and add a dependeny from the plugin library to the loader library * gb_Library_set_plugin_for_nodep,lib,loader: ^^^^ without adding the library dependeny * gb_Helper_register_plugins_for_install: "plugin" replacement for gb_Helper_register_libraries_for_install to implement some additional checks in the build system In the end this patch just adds a bit syntactic sugar and nothing changes for any build. Change-Id: I7b01d9c384cbc5838bd2cc93aff18e4868939d6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126163 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
Diffstat (limited to 'filter')
-rw-r--r--filter/Library_icg.mk2
1 files changed, 2 insertions, 0 deletions
diff --git a/filter/Library_icg.mk b/filter/Library_icg.mk
index 94949bb32904..44cb742a6b98 100644
--- a/filter/Library_icg.mk
+++ b/filter/Library_icg.mk
@@ -19,6 +19,8 @@
$(eval $(call gb_Library_Library,icg))
+$(eval $(call gb_Library_set_plugin_for_nodep,icg,sd))
+
$(eval $(call gb_Library_use_external,icg,boost_headers))
$(eval $(call gb_Library_use_sdk_api,icg))