diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-04-23 16:07:32 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2021-04-27 14:07:56 +0200 |
| commit | c7c6f0af6c836ebe0968967a1e7c8320b0ac17d6 (patch) | |
| tree | 4bc5b2fa623b9765b88bbfe7de10a7590c87d5c8 /extensions | |
| parent | 99482297c7dd497e41fad2e7193759043e305101 (diff) | |
loplugin:stringadd convert chained append to +
which can use the more efficient *StringConcat
Also fix a crash in stringview plugin which
started happening while I working on this.
Change-Id: I91a5b9b7707d1594d27d80b73930f5afac8ae608
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114568
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'extensions')
| -rw-r--r-- | extensions/source/propctrlr/selectlabeldialog.cxx | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/extensions/source/propctrlr/selectlabeldialog.cxx b/extensions/source/propctrlr/selectlabeldialog.cxx index 9cefcb72b273..1987de8d85c5 100644 --- a/extensions/source/propctrlr/selectlabeldialog.cxx +++ b/extensions/source/propctrlr/selectlabeldialog.cxx @@ -205,10 +205,9 @@ namespace pcr if (!::comphelper::hasProperty(PROPERTY_LABEL, xAsSet)) continue; - OUString sDisplayName = OUStringBuffer( - ::comphelper::getString(xAsSet->getPropertyValue(PROPERTY_LABEL))). - append(" (").append(sName).append(')'). - makeStringAndClear(); + OUString sDisplayName = + ::comphelper::getString(xAsSet->getPropertyValue(PROPERTY_LABEL)) + + " (" + sName + ")"; // all requirements met -> insert m_xUserData.emplace_back(new Reference<XPropertySet>(xAsSet)); |