loplugin:casttovoid: extensions

Change-Id: I5922341e0bb74da854307e6cb0a004395f3e8851

13 files changed, 7 insertions, 29 deletions

diff --git a/extensions/source/abpilot/datasourcehandling.cxx b/extensions/source/abpilot/datasourcehandling.cxx
index 598d476bdd3a..e543b396fc60 100644
--- a/extensions/source/abpilot/datasourcehandling.cxx
+++ b/extensions/source/abpilot/datasourcehandling.cxx
@@ -107,7 +107,6 @@ namespace abp
         Reference< XDatabaseContext > xContext = lcl_getDataSourceContext( _rxContext );
 
         DBG_ASSERT( !xContext->hasByName( _rName ), "lcl_implCreateAndInsert: name already used!" );
-        (void)_rName;
 
 
         // create a new data source
diff --git a/extensions/source/bibliography/bibview.cxx b/extensions/source/bibliography/bibview.cxx
index ae993379c67f..04f4f5e2698f 100644
--- a/extensions/source/bibliography/bibview.cxx
+++ b/extensions/source/bibliography/bibview.cxx
@@ -90,10 +90,7 @@ namespace bib
                     else
                         xResUpd->updateRow();
                 }
-                catch( const uno::Exception& rEx)
-                {
-                   (void) rEx;
-                }
+                catch( const uno::Exception&) {}
             }
         }
 
@@ -217,4 +214,4 @@ namespace bib
 }   // namespace bib
 
 
-/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
\ No newline at end of file
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/extensions/source/bibliography/formcontrolcontainer.cxx b/extensions/source/bibliography/formcontrolcontainer.cxx
index d0d7576af413..8019a772bdb0 100644
--- a/extensions/source/bibliography/formcontrolcontainer.cxx
+++ b/extensions/source/bibliography/formcontrolcontainer.cxx
@@ -98,9 +98,8 @@ namespace bib
                 ControlModeSwitch( _bDesign )
             );
         }
-        catch( const Exception& e)
+        catch( const Exception&)
         {
-            (void) e;   // make compiler happy
             OSL_FAIL( "FormControlContainer::implSetDesignMode: caught an exception!" );
         }
     }
diff --git a/extensions/source/bibliography/general.cxx b/extensions/source/bibliography/general.cxx
index 9eccfef67a0d..8c14735756b2 100644
--- a/extensions/source/bibliography/general.cxx
+++ b/extensions/source/bibliography/general.cxx
@@ -517,9 +517,8 @@ uno::Reference< awt::XControlModel >  BibGeneralPage::AddXControl(
             }
         }
     }
-    catch(const Exception& rEx)
+    catch(const Exception&)
     {
-        (void) rEx; // make compiler happy
         OSL_FAIL("BibGeneralPage::AddXControl: something went wrong!");
     }
     return xCtrModel;
diff --git a/extensions/source/propctrlr/browserlistbox.cxx b/extensions/source/propctrlr/browserlistbox.cxx
index f34a7b67b35f..231cf2ee360a 100644
--- a/extensions/source/propctrlr/browserlistbox.cxx
+++ b/extensions/source/propctrlr/browserlistbox.cxx
@@ -815,7 +815,6 @@ namespace pcr
     IMPL_LINK(OBrowserListBox, ScrollHdl, ScrollBar*, _pScrollBar, void )
     {
         DBG_ASSERT(_pScrollBar == m_aVScroll.get(), "OBrowserListBox::ScrollHdl: where does this come from?");
-        (void)_pScrollBar;
 
         // disable painting to prevent flicker
         m_aLinesPlayground->EnablePaint(false);
diff --git a/extensions/source/propctrlr/eformspropertyhandler.cxx b/extensions/source/propctrlr/eformspropertyhandler.cxx
index f6a3bb171ade..45e106db0b0f 100644
--- a/extensions/source/propctrlr/eformspropertyhandler.cxx
+++ b/extensions/source/propctrlr/eformspropertyhandler.cxx
@@ -476,7 +476,6 @@ namespace pcr
             return InteractiveSelectionResult_Cancelled;
 
         PropertyId nPropId( impl_getPropertyId_throwUnknownProperty( _rPropertyName ) );
-        (void)nPropId;
         OSL_ENSURE( ( PROPERTY_ID_BINDING_NAME == nPropId )
                  || ( PROPERTY_ID_BIND_EXPRESSION == nPropId )
                  || ( PROPERTY_ID_XSD_REQUIRED == nPropId )
diff --git a/extensions/source/propctrlr/eventhandler.cxx b/extensions/source/propctrlr/eventhandler.cxx
index 964c3ee1e800..be1b66519154 100644
--- a/extensions/source/propctrlr/eventhandler.cxx
+++ b/extensions/source/propctrlr/eventhandler.cxx
@@ -616,7 +616,6 @@ namespace pcr
 
         OSL_ENSURE( _rControlValueType.getTypeClass() == TypeClass_STRING,
             "EventHandler::convertToControlValue: unexpected ControlValue type class!" );
-        (void)_rControlValueType;
 
         OUString sScript( aScriptEvent.ScriptCode );
         if ( !sScript.isEmpty() )
diff --git a/extensions/source/propctrlr/selectlabeldialog.cxx b/extensions/source/propctrlr/selectlabeldialog.cxx
index 36edf9b6313e..a9d42ca70813 100644
--- a/extensions/source/propctrlr/selectlabeldialog.cxx
+++ b/extensions/source/propctrlr/selectlabeldialog.cxx
@@ -244,7 +244,6 @@ namespace pcr
     IMPL_LINK(OSelectLabelDialog, OnEntrySelected, SvTreeListBox*, pLB, void)
     {
         DBG_ASSERT(pLB == m_pControlTree, "OSelectLabelDialog::OnEntrySelected : where did this come from ?");
-        (void)pLB;
         SvTreeListEntry* pSelected = m_pControlTree->FirstSelected();
         void* pData = pSelected ? pSelected->GetUserData() : nullptr;
 
@@ -260,7 +259,6 @@ namespace pcr
     IMPL_LINK(OSelectLabelDialog, OnNoAssignmentClicked, Button*, pButton, void)
     {
         DBG_ASSERT(pButton == m_pNoAssignment, "OSelectLabelDialog::OnNoAssignmentClicked : where did this come from ?");
-        (void)pButton;
 
         if (m_pNoAssignment->IsChecked())
             m_pLastSelected = m_pControlTree->FirstSelected();
diff --git a/extensions/source/propctrlr/submissionhandler.cxx b/extensions/source/propctrlr/submissionhandler.cxx
index bef6d5990aac..89d4b312b629 100644
--- a/extensions/source/propctrlr/submissionhandler.cxx
+++ b/extensions/source/propctrlr/submissionhandler.cxx
@@ -389,7 +389,6 @@ namespace pcr
 
         OSL_ENSURE( _rControlValueType.getTypeClass() == TypeClass_STRING,
             "SubmissionPropertyHandler::convertToControlValue: all our controls should use strings for value exchange!" );
-        (void)_rControlValueType;
 
         PropertyId nPropId( m_pInfoService->getPropertyId( _rPropertyName ) );
         switch ( nPropId )
diff --git a/extensions/source/propctrlr/taborder.cxx b/extensions/source/propctrlr/taborder.cxx
index 580ffca78cb2..5a68e8b42f1e 100644
--- a/extensions/source/propctrlr/taborder.cxx
+++ b/extensions/source/propctrlr/taborder.cxx
@@ -353,12 +353,6 @@ namespace pcr
 
                 if( (nLastSelPos + nRelPos - i) > (GetEntryCount()-1) ) return;
 
-#if OSL_DEBUG_LEVEL > 0
-                sal_uLong nSelCount = GetSelectionCount();
-                (void)nSelCount;
-#endif
-
-
                 SvTreeListEntry* pSelEntry = pLastSelected;
                 while( pSelEntry )
                 {
diff --git a/extensions/source/scanner/sane.cxx b/extensions/source/scanner/sane.cxx
index 99195750eaef..a790375485b9 100644
--- a/extensions/source/scanner/sane.cxx
+++ b/extensions/source/scanner/sane.cxx
@@ -668,7 +668,7 @@ bool Sane::Start( BitmapTransporter& rBitmap )
                 bSynchronousRead = false;
                 nStatus = p_set_io_mode( maHandle, SANE_TRUE );
                 CheckConsistency( "sane_set_io_mode" );
-                SAL_WARN_IF(nStatus != SANE_STATUS_GOOD, "extensions.scanner", "driver is confused" ); (void)nStatus;
+                SAL_WARN_IF(nStatus != SANE_STATUS_GOOD, "extensions.scanner", "driver is confused" );
             }
 
             SANE_Int nLen=0;
diff --git a/extensions/source/update/check/download.cxx b/extensions/source/update/check/download.cxx
index fea4649d64ce..4e557f02a8f1 100644
--- a/extensions/source/update/check/download.cxx
+++ b/extensions/source/update/check/download.cxx
@@ -142,11 +142,8 @@ write_function( void *ptr, size_t size, size_t nmemb, void *stream )
 
 
 static int
-progress_callback( void *clientp, double dltotal, double dlnow, double ultotal, double ulnow )
+progress_callback( void *clientp, double dltotal, double dlnow, SAL_UNUSED_PARAMETER double, SAL_UNUSED_PARAMETER double )
 {
-    (void) ultotal;
-    (void) ulnow;
-
     OutData *out = static_cast < OutData * > (clientp);
 
     assert(out);
diff --git a/extensions/source/update/check/updatecheck.cxx b/extensions/source/update/check/updatecheck.cxx
index 895a07f81baf..7037bf93ea29 100644
--- a/extensions/source/update/check/updatecheck.cxx
+++ b/extensions/source/update/check/updatecheck.cxx
@@ -900,8 +900,7 @@ UpdateCheck::install()
         rModel->clearLocalFileName();
 
         xShellExecute->execute(aInstallImage, aParameter, nFlags);
-        ShutdownThread *pShutdownThread = new ShutdownThread( m_xContext );
-        (void) pShutdownThread;
+        new ShutdownThread( m_xContext );
     } catch(const uno::Exception&) {
         m_aUpdateHandler->setErrorMessage( m_aUpdateHandler->getDefaultInstErrMsg() );
     }