diff options
| author | Mike Kaganski <mike.kaganski@collabora.com> | 2019-08-22 15:42:36 +0300 |
|---|---|---|
| committer | Mike Kaganski <mike.kaganski@collabora.com> | 2019-08-23 11:48:53 +0200 |
| commit | 63dfd069b3a957361881c12ccba38c5a23b9a42f (patch) | |
| tree | e7a9bd1027b19f44a7c58ea9c445ded435c838bc /extensions | |
| parent | 61ed17cafc90d9b4303b52260f729638eed107c7 (diff) | |
Mark move ctors/assignments noexcept
This should enable using move semantics where possible e.g. in standard
containers.
According to https://en.cppreference.com/w/cpp/language/move_constructor:
To make strong exception guarantee possible, user-defined move
constructors should not throw exceptions. For example, std::vector
relies on std::move_if_noexcept to choose between move and copy
when the elements need to be relocated.
Change-Id: I6e1e1cdd5cd430b139ffa2fa7031fb0bb625decb
Reviewed-on: https://gerrit.libreoffice.org/77957
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'extensions')
| -rw-r--r-- | extensions/source/abpilot/datasourcehandling.cxx | 2 | ||||
| -rw-r--r-- | extensions/source/abpilot/datasourcehandling.hxx | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/extensions/source/abpilot/datasourcehandling.cxx b/extensions/source/abpilot/datasourcehandling.cxx index fdcf218f4826..3f121bc4d5bd 100644 --- a/extensions/source/abpilot/datasourcehandling.cxx +++ b/extensions/source/abpilot/datasourcehandling.cxx @@ -320,7 +320,7 @@ namespace abp return *this; } - ODataSource& ODataSource::operator=( ODataSource&& _rSource ) + ODataSource& ODataSource::operator=(ODataSource&& _rSource) noexcept { m_pImpl = std::move(_rSource.m_pImpl); return *this; diff --git a/extensions/source/abpilot/datasourcehandling.hxx b/extensions/source/abpilot/datasourcehandling.hxx index f5037915bdf2..00da09f7941d 100644 --- a/extensions/source/abpilot/datasourcehandling.hxx +++ b/extensions/source/abpilot/datasourcehandling.hxx @@ -117,7 +117,7 @@ namespace abp ODataSource& operator=( const ODataSource& _rSource ); /// move assignment - ODataSource& operator=( ODataSource&& _rSource ); + ODataSource& operator=(ODataSource&& _rSource) noexcept; /// checks whether or not the object represents a valid data source bool isValid() const; |