summaryrefslogtreecommitdiff
path: root/extensions
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2016-08-18 12:27:49 +0100
committerCaolán McNamara <caolanm@redhat.com>2016-08-18 14:24:11 +0100
commit4630157e29f565c110f4fa11223a2d2358508c26 (patch)
treef27b9b6e953ec3ae433172229a596ab0bdc9d934 /extensions
parent8a6eb111609fbb1e0270ef5ba475b027635c9749 (diff)
cppcheck: passedByValue
Change-Id: I3ffcfe1294a1cbb06aadd3a1a79e9259876e38cc
Diffstat (limited to 'extensions')
-rw-r--r--extensions/source/propctrlr/browserlistbox.hxx2
-rw-r--r--extensions/source/resource/ResourceIndexAccess.cxx6
-rw-r--r--extensions/source/scanner/scanunx.cxx7
3 files changed, 7 insertions, 8 deletions
diff --git a/extensions/source/propctrlr/browserlistbox.hxx b/extensions/source/propctrlr/browserlistbox.hxx
index 284119c97c3f..9ba18cdde797 100644
--- a/extensions/source/propctrlr/browserlistbox.hxx
+++ b/extensions/source/propctrlr/browserlistbox.hxx
@@ -59,7 +59,7 @@ namespace pcr
css::uno::Reference< css::inspection::XPropertyHandler >
xHandler;
- ListBoxLine( const OUString& rName, BrowserLinePointer _pLine, const css::uno::Reference< css::inspection::XPropertyHandler >& _rxHandler )
+ ListBoxLine( const OUString& rName, const BrowserLinePointer& _pLine, const css::uno::Reference< css::inspection::XPropertyHandler >& _rxHandler )
: aName( rName ),
pLine( _pLine ),
xHandler( _rxHandler )
diff --git a/extensions/source/resource/ResourceIndexAccess.cxx b/extensions/source/resource/ResourceIndexAccess.cxx
index 5141b209834b..f8a35b859388 100644
--- a/extensions/source/resource/ResourceIndexAccess.cxx
+++ b/extensions/source/resource/ResourceIndexAccess.cxx
@@ -40,7 +40,7 @@ namespace
class ResourceIndexAccessBase : public cppu::WeakImplHelper< css::container::XIndexAccess>
{
public:
- explicit ResourceIndexAccessBase( std::shared_ptr<ResMgr> pResMgr)
+ explicit ResourceIndexAccessBase(const std::shared_ptr<ResMgr>& pResMgr)
: m_pResMgr(pResMgr)
{
OSL_ENSURE(m_pResMgr, "no resource manager given");
@@ -61,7 +61,7 @@ namespace
class ResourceStringIndexAccess : public ResourceIndexAccessBase
{
public:
- explicit ResourceStringIndexAccess( std::shared_ptr<ResMgr> pResMgr)
+ explicit ResourceStringIndexAccess(const std::shared_ptr<ResMgr>& pResMgr)
: ResourceIndexAccessBase(pResMgr) {}
// XIndexAccess
virtual css::uno::Any SAL_CALL getByIndex( ::sal_Int32 Index ) throw (css::lang::IndexOutOfBoundsException, css::lang::WrappedTargetException, css::uno::RuntimeException, std::exception) override;
@@ -73,7 +73,7 @@ namespace
class ResourceStringListIndexAccess : public ResourceIndexAccessBase
{
public:
- explicit ResourceStringListIndexAccess( std::shared_ptr<ResMgr> pResMgr)
+ explicit ResourceStringListIndexAccess(const std::shared_ptr<ResMgr>& pResMgr)
: ResourceIndexAccessBase(pResMgr) {}
// XIndexAccess
virtual css::uno::Any SAL_CALL getByIndex( ::sal_Int32 Index ) throw (css::lang::IndexOutOfBoundsException, css::lang::WrappedTargetException, css::uno::RuntimeException, std::exception) override;
diff --git a/extensions/source/scanner/scanunx.cxx b/extensions/source/scanner/scanunx.cxx
index 268ab107e91f..a57f52961673 100644
--- a/extensions/source/scanner/scanunx.cxx
+++ b/extensions/source/scanner/scanunx.cxx
@@ -132,17 +132,16 @@ public:
virtual void run() override;
virtual void onTerminated() override { delete this; }
public:
- ScannerThread( std::shared_ptr<SaneHolder> pHolder,
+ ScannerThread( const std::shared_ptr<SaneHolder>& pHolder,
const Reference< css::lang::XEventListener >& listener,
ScannerManager* pManager );
virtual ~ScannerThread();
};
-ScannerThread::ScannerThread(
- std::shared_ptr<SaneHolder> pHolder,
+ScannerThread::ScannerThread(const std::shared_ptr<SaneHolder>& pHolder,
const Reference< css::lang::XEventListener >& listener,
- ScannerManager* pManager )
+ ScannerManager* pManager)
: m_pHolder( pHolder ), m_xListener( listener ), m_pManager( pManager )
{
SAL_INFO("extensions.scanner", "ScannerThread");