diff options
| author | Noel Grandin <noel@peralex.com> | 2015-10-15 12:28:31 +0200 |
|---|---|---|
| committer | Noel Grandin <noel@peralex.com> | 2015-10-15 12:29:01 +0200 |
| commit | 0e8a40e8b8c883611b6d34e47dc6e33ba60e0f91 (patch) | |
| tree | 92e49014bb9b368309c98d85dcfbd2f673e23d54 /extensions | |
| parent | cfc7307a23eed561152c1b016cd0ec22bc7af145 (diff) | |
calling IsSet() before Call() on Link<> is unnecessary
the Call() already does a check
Found with:
git grep -A 1 -w 'IsSet()'
| grep -B 1 '.Call('
| grep ':'
| cut -d ':' -f 1
Change-Id: Ia7248f5d62640b75f705e539c3d1183e39c0d847
Diffstat (limited to 'extensions')
| -rw-r--r-- | extensions/source/propctrlr/browserview.cxx | 3 | ||||
| -rw-r--r-- | extensions/source/propctrlr/formlinkdialog.cxx | 5 | ||||
| -rw-r--r-- | extensions/source/propctrlr/propertyeditor.cxx | 3 | ||||
| -rw-r--r-- | extensions/source/propctrlr/sqlcommanddesign.cxx | 3 |
4 files changed, 4 insertions, 10 deletions
diff --git a/extensions/source/propctrlr/browserview.cxx b/extensions/source/propctrlr/browserview.cxx index 63235def840d..1c83d4b8af7e 100644 --- a/extensions/source/propctrlr/browserview.cxx +++ b/extensions/source/propctrlr/browserview.cxx @@ -43,8 +43,7 @@ namespace pcr IMPL_LINK_NOARG_TYPED(OPropertyBrowserView, OnPageActivation, LinkParamNone*, void) { m_nActivePage = m_pPropBox->GetCurPage(); - if (m_aPageActivationHandler.IsSet()) - m_aPageActivationHandler.Call(NULL); + m_aPageActivationHandler.Call(NULL); } diff --git a/extensions/source/propctrlr/formlinkdialog.cxx b/extensions/source/propctrlr/formlinkdialog.cxx index 5b9c0e648dd8..600bb7208404 100644 --- a/extensions/source/propctrlr/formlinkdialog.cxx +++ b/extensions/source/propctrlr/formlinkdialog.cxx @@ -149,10 +149,7 @@ namespace pcr IMPL_LINK( FieldLinkRow, OnFieldNameChanged, ComboBox*, /*_pBox*/ ) { - if ( m_aLinkChangeHandler.IsSet() ) - return m_aLinkChangeHandler.Call( this ); - - return 0L; + return m_aLinkChangeHandler.Call( this ); } VCL_BUILDER_FACTORY(FieldLinkRow) diff --git a/extensions/source/propctrlr/propertyeditor.cxx b/extensions/source/propctrlr/propertyeditor.cxx index 126ee9284956..5586aa3affda 100644 --- a/extensions/source/propctrlr/propertyeditor.cxx +++ b/extensions/source/propctrlr/propertyeditor.cxx @@ -511,8 +511,7 @@ namespace pcr IMPL_LINK_NOARG_TYPED(OPropertyEditor, OnPageActivate, TabControl*, void) { - if (m_aPageActivationHandler.IsSet()) - m_aPageActivationHandler.Call(NULL); + m_aPageActivationHandler.Call(NULL); } diff --git a/extensions/source/propctrlr/sqlcommanddesign.cxx b/extensions/source/propctrlr/sqlcommanddesign.cxx index cb9f003007df..4aff1ef70d6c 100644 --- a/extensions/source/propctrlr/sqlcommanddesign.cxx +++ b/extensions/source/propctrlr/sqlcommanddesign.cxx @@ -309,8 +309,7 @@ namespace pcr void SQLCommandDesigner::impl_designerClosed_nothrow() { - if ( m_aCloseLink.IsSet() ) - m_aCloseLink.Call( *this ); + m_aCloseLink.Call( *this ); } |