loplugin:unuseddefaultparams various

Change-Id: Ibf8489c957b307156689de4c7cb8440ddd4e4546
Reviewed-on: https://gerrit.libreoffice.org/22852
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>

8 files changed, 17 insertions, 22 deletions

diff --git a/extensions/source/bibliography/toolbar.cxx b/extensions/source/bibliography/toolbar.cxx
index cf581286e8a4..521ef5a0cfb4 100644
--- a/extensions/source/bibliography/toolbar.cxx
+++ b/extensions/source/bibliography/toolbar.cxx
@@ -409,9 +409,9 @@ void BibToolBar::UpdateSourceList(bool bFlag)
     aLBSource->SetUpdateMode(bFlag);
 }
 
-void BibToolBar::InsertSourceEntry(const OUString& aEntry, sal_Int32 nPos)
+void BibToolBar::InsertSourceEntry(const OUString& aEntry)
 {
-    aLBSource->InsertEntry(aEntry, nPos);
+    aLBSource->InsertEntry(aEntry);
 }
 
 void BibToolBar::SelectSourceEntry(const OUString& aStr)
diff --git a/extensions/source/bibliography/toolbar.hxx b/extensions/source/bibliography/toolbar.hxx
index dd3d4bdda772..c051912d4bdd 100644
--- a/extensions/source/bibliography/toolbar.hxx
+++ b/extensions/source/bibliography/toolbar.hxx
@@ -154,7 +154,7 @@ class BibToolBar:   public ToolBox
         void    ClearSourceList();
         void    UpdateSourceList(bool bFlag=true);
         void    EnableSourceList(bool bFlag=true);
-        void    InsertSourceEntry(const OUString&,sal_Int32  nPos=LISTBOX_APPEND );
+        void    InsertSourceEntry(const OUString& );
         void    SelectSourceEntry(const OUString& );
 
         void    EnableQuery(bool bFlag=true);
diff --git a/extensions/source/dbpilots/controlwizard.cxx b/extensions/source/dbpilots/controlwizard.cxx
index 2e8f25329dbb..f220adb5a75b 100644
--- a/extensions/source/dbpilots/controlwizard.cxx
+++ b/extensions/source/dbpilots/controlwizard.cxx
@@ -135,10 +135,9 @@ namespace dbp
     }
 
 
-    void OControlWizardPage::fillListBox(ListBox& _rList, const Sequence< OUString >& _rItems, bool _bClear)
+    void OControlWizardPage::fillListBox(ListBox& _rList, const Sequence< OUString >& _rItems)
     {
-        if (_bClear)
-            _rList.Clear();
+        _rList.Clear();
         const OUString* pItems = _rItems.getConstArray();
         const OUString* pEnd = pItems + _rItems.getLength();
         ::svt::WizardTypes::WizardState nPos;
@@ -151,10 +150,9 @@ namespace dbp
     }
 
 
-    void OControlWizardPage::fillListBox(ComboBox& _rList, const Sequence< OUString >& _rItems, bool _bClear)
+    void OControlWizardPage::fillListBox(ComboBox& _rList, const Sequence< OUString >& _rItems)
     {
-        if (_bClear)
-            _rList.Clear();
+        _rList.Clear();
         const OUString* pItems = _rItems.getConstArray();
         const OUString* pEnd = pItems + _rItems.getLength();
         ::svt::WizardTypes::WizardState nPos;
diff --git a/extensions/source/dbpilots/controlwizard.hxx b/extensions/source/dbpilots/controlwizard.hxx
index 51ca221d9e8d..3f2e44daa090 100644
--- a/extensions/source/dbpilots/controlwizard.hxx
+++ b/extensions/source/dbpilots/controlwizard.hxx
@@ -72,12 +72,10 @@ namespace dbp
     protected:
         static void fillListBox(
             ListBox& _rList,
-            const css::uno::Sequence< OUString >& _rItems,
-            bool _bClear = true);
+            const css::uno::Sequence< OUString >& _rItems);
         static void fillListBox(
             ComboBox& _rList,
-            const css::uno::Sequence< OUString >& _rItems,
-            bool _bClear = true);
+            const css::uno::Sequence< OUString >& _rItems);
 
     protected:
         void enableFormDatasourceDisplay();
diff --git a/extensions/source/propctrlr/propertyeditor.cxx b/extensions/source/propctrlr/propertyeditor.cxx
index 0d7113cc1d34..fd401e5bd8f2 100644
--- a/extensions/source/propctrlr/propertyeditor.cxx
+++ b/extensions/source/propctrlr/propertyeditor.cxx
@@ -297,7 +297,7 @@ namespace pcr
     }
 
 
-    void OPropertyEditor::forEachPage( PageOperation _pOperation, const void* _pArgument )
+    void OPropertyEditor::forEachPage( PageOperation _pOperation )
     {
         sal_uInt16 nCount = m_aTabControl->GetPageCount();
         for ( sal_uInt16 i=0; i<nCount; ++i )
@@ -306,7 +306,7 @@ namespace pcr
             OBrowserPage* pPage = static_cast< OBrowserPage* >( m_aTabControl->GetTabPage( nID ) );
             if ( !pPage )
                 continue;
-            (this->*_pOperation)( *pPage, _pArgument );
+            (this->*_pOperation)( *pPage, nullptr );
         }
     }
 
diff --git a/extensions/source/propctrlr/propertyeditor.hxx b/extensions/source/propctrlr/propertyeditor.hxx
index 3a9bf85ca916..6162d3e1bfb7 100644
--- a/extensions/source/propctrlr/propertyeditor.hxx
+++ b/extensions/source/propctrlr/propertyeditor.hxx
@@ -127,7 +127,7 @@ namespace pcr
         void Update(const ::std::mem_fun_t<void,OBrowserListBox>& _aUpdateFunction);
 
         typedef void (OPropertyEditor::*PageOperation)( OBrowserPage&, const void* );
-        void    forEachPage( PageOperation _pOperation, const void* _pArgument = nullptr );
+        void    forEachPage( PageOperation _pOperation );
 
         void    setPageLineListener( OBrowserPage& _rPage, const void* );
         void    setPageControlObserver( OBrowserPage& _rPage, const void* );
diff --git a/extensions/source/propctrlr/propertyhandler.hxx b/extensions/source/propctrlr/propertyhandler.hxx
index 91fa5e2819c0..8af12129fe2f 100644
--- a/extensions/source/propctrlr/propertyhandler.hxx
+++ b/extensions/source/propctrlr/propertyhandler.hxx
@@ -165,8 +165,7 @@ namespace pcr
         */
         inline void addStringPropertyDescription(
                     ::std::vector< css::beans::Property >& _rProperties,
-                    const OUString& _rPropertyName,
-                    sal_Int16 _nAttribs = 0
+                    const OUString& _rPropertyName
                 ) const;
 
         /** adds a description for the given int32 property to the given property vector
@@ -304,9 +303,9 @@ namespace pcr
     };
 
 
-    inline void PropertyHandler::addStringPropertyDescription( ::std::vector< css::beans::Property >& _rProperties, const OUString& _rPropertyName, sal_Int16 _nAttribs ) const
+    inline void PropertyHandler::addStringPropertyDescription( ::std::vector< css::beans::Property >& _rProperties, const OUString& _rPropertyName ) const
     {
-        implAddPropertyDescription( _rProperties, _rPropertyName, ::cppu::UnoType<OUString>::get(), _nAttribs );
+        implAddPropertyDescription( _rProperties, _rPropertyName, ::cppu::UnoType<OUString>::get() );
     }
 
     inline void PropertyHandler::addInt32PropertyDescription( ::std::vector< css::beans::Property >& _rProperties, const OUString& _rPropertyName, sal_Int16 _nAttribs ) const
diff --git a/extensions/source/update/check/download.cxx b/extensions/source/update/check/download.cxx
index e2046f9b2ef7..43320b51fbdc 100644
--- a/extensions/source/update/check/download.cxx
+++ b/extensions/source/update/check/download.cxx
@@ -113,12 +113,12 @@ getStringValue(const uno::Reference< container::XNameAccess >& xNameAccess, cons
 
 static inline sal_Int32
 getInt32Value(const uno::Reference< container::XNameAccess >& xNameAccess,
-                    const OUString& aName, sal_Int32 nDefault=-1)
+                    const OUString& aName)
 {
     OSL_ASSERT(xNameAccess->hasByName(aName));
     uno::Any aValue = xNameAccess->getByName(aName);
 
-    sal_Int32 n=nDefault;
+    sal_Int32 n = -1;
     aValue >>= n;
     return n;
 }