diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2017-01-26 12:28:58 +0100 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2017-01-26 12:54:43 +0000 |
commit | e57ca02849c3d87142ff5ff9099a212e72b8139c (patch) | |
tree | bcce66b27261553c308779f3e8663a269ed3a671 /desktop/source/pkgchk/unopkg/unopkg_cmdenv.cxx | |
parent | 8802ebd5172ec4bc412a59d136c82b77ab452281 (diff) |
Remove dynamic exception specifications
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html>
"Dynamic Exception Specifications" for details.
Most changes have been done automatically by the rewriting loplugin:dynexcspec
(after enabling the rewriting mode, to be committed shortly). The way it only
removes exception specs from declarations if it also sees a definition, it
identified some dead declarations-w/o-definitions (that have been removed
manually) and some cases where a definition appeared in multiple include files
(which have also been cleaned up manually). There's also been cases of macro
paramters (that were used to abstract over exception specs) that have become
unused now (and been removed).
Furthermore, some code needed to be cleaned up manually
(avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no
configurations available that would actually build that code. Missing @throws
documentation has not been applied in such manual clean-up.
Change-Id: I3408691256c9b0c12bc5332de976743626e13960
Reviewed-on: https://gerrit.libreoffice.org/33574
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'desktop/source/pkgchk/unopkg/unopkg_cmdenv.cxx')
-rw-r--r-- | desktop/source/pkgchk/unopkg/unopkg_cmdenv.cxx | 25 |
1 files changed, 9 insertions, 16 deletions
diff --git a/desktop/source/pkgchk/unopkg/unopkg_cmdenv.cxx b/desktop/source/pkgchk/unopkg/unopkg_cmdenv.cxx index 2de8302b6020..a47d4b81761b 100644 --- a/desktop/source/pkgchk/unopkg/unopkg_cmdenv.cxx +++ b/desktop/source/pkgchk/unopkg/unopkg_cmdenv.cxx @@ -64,7 +64,7 @@ class CommandEnvironmentImpl Reference< XProgressHandler > m_xLogFile; /// @throws RuntimeException - void update_( Any const & Status ) throw (RuntimeException); + void update_( Any const & Status ); void printLicense(const OUString & sName,const OUString& sLicense, bool & accept, bool & decline); @@ -79,19 +79,17 @@ public: // XCommandEnvironment virtual Reference< task::XInteractionHandler > SAL_CALL - getInteractionHandler() throw (RuntimeException, std::exception) override; - virtual Reference< XProgressHandler > SAL_CALL getProgressHandler() - throw (RuntimeException, std::exception) override; + getInteractionHandler() override; + virtual Reference< XProgressHandler > SAL_CALL getProgressHandler() override; // XInteractionHandler virtual void SAL_CALL handle( - Reference< task::XInteractionRequest > const & xRequest ) - throw (RuntimeException, std::exception) override; + Reference< task::XInteractionRequest > const & xRequest ) override; // XProgressHandler - virtual void SAL_CALL push( Any const & Status ) throw (RuntimeException, std::exception) override; - virtual void SAL_CALL update( Any const & Status ) throw (RuntimeException, std::exception) override; - virtual void SAL_CALL pop() throw (RuntimeException, std::exception) override; + virtual void SAL_CALL push( Any const & Status ) override; + virtual void SAL_CALL update( Any const & Status ) override; + virtual void SAL_CALL pop() override; }; @@ -188,14 +186,13 @@ void CommandEnvironmentImpl::printLicense( // XCommandEnvironment Reference< task::XInteractionHandler > -CommandEnvironmentImpl::getInteractionHandler() throw (RuntimeException, std::exception) +CommandEnvironmentImpl::getInteractionHandler() { return this; } Reference< XProgressHandler > CommandEnvironmentImpl::getProgressHandler() - throw (RuntimeException, std::exception) { return this; } @@ -204,7 +201,6 @@ Reference< XProgressHandler > CommandEnvironmentImpl::getProgressHandler() void CommandEnvironmentImpl::handle( Reference<task::XInteractionRequest> const & xRequest ) - throw (RuntimeException, std::exception) { Any request( xRequest->getRequest() ); OSL_ASSERT( request.getValueTypeClass() == TypeClass_EXCEPTION ); @@ -323,7 +319,6 @@ void CommandEnvironmentImpl::handle( // XProgressHandler void CommandEnvironmentImpl::push( Any const & Status ) - throw (RuntimeException, std::exception) { update_( Status ); OSL_ASSERT( m_logLevel >= 0 ); @@ -334,7 +329,6 @@ void CommandEnvironmentImpl::push( Any const & Status ) void CommandEnvironmentImpl::update_( Any const & Status ) - throw (RuntimeException) { if (! Status.hasValue()) return; @@ -376,7 +370,6 @@ void CommandEnvironmentImpl::update_( Any const & Status ) void CommandEnvironmentImpl::update( Any const & Status ) - throw (RuntimeException, std::exception) { update_( Status ); if (m_xLogFile.is()) @@ -384,7 +377,7 @@ void CommandEnvironmentImpl::update( Any const & Status ) } -void CommandEnvironmentImpl::pop() throw (RuntimeException, std::exception) +void CommandEnvironmentImpl::pop() { OSL_ASSERT( m_logLevel > 0 ); --m_logLevel; |