diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2019-10-14 11:42:20 +0200 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2019-10-14 15:48:38 +0200 |
| commit | 77d083f2cbe496274cdab38a3a34497d1b742d86 (patch) | |
| tree | 7092c7dbd5d746deb30565d8670dd79246327b58 /desktop/source/app | |
| parent | de2cb96d5f9bb3c831fd136062582b4c11a003d1 (diff) | |
New loplugin:getstr
...to find matches of
... << s.getStr()
(for the rtl string classes) that can be written as just
... << s
Some notes:
* The OUStringToOString(..., RTL_TEXTENCODING_UTF8) is left explicit in
desktop/source/app/crashreport.cxx (even though that would also be done
internally by the "<< OUString" operator) to clarify that these values are
written out as UTF-8 (and not as what that operator << happens to use, which
just also happens to be UTF-8).
* OUSTRING_TO_CSTR (include/oox/helper/helper.hxx) is no longer used now.
* Just don't bother to use osl_getThreadTextEncoding() in the SAL_WARN in
lingucomponent/source/hyphenator/hyphen/hyphenimp.cxx.
* The toUtf8() in the SAL_DEBUG in pyuno/source/module/pyuno_module.cxx can just
go, too.
Change-Id: I4602f0379ef816bff310f1e51b57c56b7e3f0136
Reviewed-on: https://gerrit.libreoffice.org/80762
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'desktop/source/app')
| -rw-r--r-- | desktop/source/app/crashreport.cxx | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/desktop/source/app/crashreport.cxx b/desktop/source/app/crashreport.cxx index 794e4e6b6b63..3420f20c4496 100644 --- a/desktop/source/app/crashreport.cxx +++ b/desktop/source/app/crashreport.cxx @@ -50,8 +50,8 @@ void CrashReporter::writeToFile(std::ios_base::openmode Openmode) for (auto& keyValue : maKeyValues) { - ini_file << OUStringToOString(keyValue.first, RTL_TEXTENCODING_UTF8).getStr() << "="; - ini_file << OUStringToOString(keyValue.second, RTL_TEXTENCODING_UTF8).getStr() << "\n"; + ini_file << OUStringToOString(keyValue.first, RTL_TEXTENCODING_UTF8) << "="; + ini_file << OUStringToOString(keyValue.second, RTL_TEXTENCODING_UTF8) << "\n"; } maKeyValues.clear(); |