ITEM: Move Shareable ItemFlag to SfxPolItem

Currently a Pool-Attribute (in SfxItemInfo), but should
be a SfxPoolItem property. Originally 'moved' from old
'poolable' used as hint. I identified needs more general
and moved it to where it belongs.

Also reworked SfxItemInfo to no longer have/support
single bollean flags, but a FlagVariable and defined
SFX_ITEMINFOFLAG_* entries to access these, that will
make future changes easier without having to change
all palces where these get defined over and over again.

Added CheckItemInfoFlag for gereral access to that flag
and e.g. NeedsSurrogateSupport to directly check for
the SFX_ITEMINFOFLAG_SUPPORT_SURROGATE flag as syntactical
sugar, that makes the intention clear.

Change-Id: I09c238c7c5b7f721b657d7b0a44dbc8d14e02528
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161982
Tested-by: Jenkins
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>

2 files changed, 68 insertions, 68 deletions

diff --git a/dbaccess/source/ui/dlg/dbadmin.cxx b/dbaccess/source/ui/dlg/dbadmin.cxx
index 372e72e258a7..8fe5d8a5bd27 100644
--- a/dbaccess/source/ui/dlg/dbadmin.cxx
+++ b/dbaccess/source/ui/dlg/dbadmin.cxx
@@ -340,68 +340,68 @@ void ODbAdminDialog::createItemSet(std::unique_ptr<SfxItemSet>& _rpSet, rtl::Ref
     // create the pool
     static SfxItemInfo const aItemInfos[DSID_LAST_ITEM_ID - DSID_FIRST_ITEM_ID + 1] =
     {
-        // _nSID, _bNeedsPoolRegistration, _bShareable
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
-        {0,false,false},
+        // _nItemInfoSlotID, _nItemInfoFlags
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
+        {0, SFX_ITEMINFOFLAG_NONE },
     };
 
     OSL_ENSURE(std::size(aItemInfos) == sal_uInt16(DSID_LAST_ITEM_ID),"Invalid Ids!");
diff --git a/dbaccess/source/ui/misc/UITools.cxx b/dbaccess/source/ui/misc/UITools.cxx
index 483afced1082..d08e1f076d26 100644
--- a/dbaccess/source/ui/misc/UITools.cxx
+++ b/dbaccess/source/ui/misc/UITools.cxx
@@ -763,12 +763,12 @@ bool callColumnFormatDialog(weld::Widget* _pParent,
     // UNO->ItemSet
     static SfxItemInfo aItemInfos[] =
     {
-        // _nSID, _bNeedsPoolRegistration, _bShareable
-        { 0,                                false, true },    // SBA_DEF_RANGEFORMAT
-        { SID_ATTR_NUMBERFORMAT_VALUE,      false, true },    // SBA_DEF_FMTVALUE
-        { SID_ATTR_ALIGN_HOR_JUSTIFY,       false, true },    // SBA_ATTR_ALIGN_HOR_JUSTIFY
-        { SID_ATTR_NUMBERFORMAT_INFO,       false, true },    // SID_ATTR_NUMBERFORMAT_INFO
-        { SID_ATTR_NUMBERFORMAT_ONE_AREA,   false, true }     // SID_ATTR_NUMBERFORMAT_ONE_AREA
+        // _nItemInfoSlotID, _nItemInfoFlags
+        { 0,                                SFX_ITEMINFOFLAG_NONE },    // SBA_DEF_RANGEFORMAT
+        { SID_ATTR_NUMBERFORMAT_VALUE,      SFX_ITEMINFOFLAG_NONE },    // SBA_DEF_FMTVALUE
+        { SID_ATTR_ALIGN_HOR_JUSTIFY,       SFX_ITEMINFOFLAG_NONE },    // SBA_ATTR_ALIGN_HOR_JUSTIFY
+        { SID_ATTR_NUMBERFORMAT_INFO,       SFX_ITEMINFOFLAG_NONE },    // SID_ATTR_NUMBERFORMAT_INFO
+        { SID_ATTR_NUMBERFORMAT_ONE_AREA,   SFX_ITEMINFOFLAG_NONE }     // SID_ATTR_NUMBERFORMAT_ONE_AREA
     };
     static const auto aAttrMap = svl::Items<
         SBA_DEF_RANGEFORMAT, SBA_ATTR_ALIGN_HOR_JUSTIFY,