loplugin:constantparam

Change-Id: Ia9500b25602c14aadf49fe373682ae9d87a0a1a2
Reviewed-on: https://gerrit.libreoffice.org/37390
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

10 files changed, 22 insertions, 31 deletions

diff --git a/dbaccess/source/core/api/querycontainer.cxx b/dbaccess/source/core/api/querycontainer.cxx
index 7e96da269a4b..0d3add13f1a6 100644
--- a/dbaccess/source/core/api/querycontainer.cxx
+++ b/dbaccess/source/core/api/querycontainer.cxx
@@ -298,7 +298,7 @@ Reference< XVeto > SAL_CALL OQueryContainer::approveInsertElement( const Contain
     }
     catch( const Exception& )
     {
-        xReturn = new Veto( OUString(), ::cppu::getCaughtException() );
+        xReturn = new Veto( ::cppu::getCaughtException() );
     }
     return xReturn;
 }
diff --git a/dbaccess/source/core/inc/veto.hxx b/dbaccess/source/core/inc/veto.hxx
index 5d3f3bf5c8ca..63a0748b24af 100644
--- a/dbaccess/source/core/inc/veto.hxx
+++ b/dbaccess/source/core/inc/veto.hxx
@@ -35,11 +35,10 @@ namespace dbaccess
     class Veto : public Veto_Base
     {
     private:
-        const OUString         m_sReason;
         const css::uno::Any    m_aDetails;
 
     public:
-        Veto( const OUString& _rReason, const css::uno::Any& _rDetails );
+        Veto( const css::uno::Any& _rDetails );
 
         virtual OUString SAL_CALL getReason() override;
         virtual css::uno::Any SAL_CALL getDetails() override;
diff --git a/dbaccess/source/core/misc/veto.cxx b/dbaccess/source/core/misc/veto.cxx
index 81331252cfbc..d716fa364766 100644
--- a/dbaccess/source/core/misc/veto.cxx
+++ b/dbaccess/source/core/misc/veto.cxx
@@ -26,9 +26,8 @@ namespace dbaccess
     using ::com::sun::star::uno::RuntimeException;
 
     // Veto
-    Veto::Veto( const OUString& _rReason, const Any& _rDetails )
-        :m_sReason( _rReason )
-        ,m_aDetails( _rDetails )
+    Veto::Veto( const Any& _rDetails )
+        :m_aDetails( _rDetails )
     {
     }
 
@@ -38,7 +37,7 @@ namespace dbaccess
 
     OUString SAL_CALL Veto::getReason()
     {
-        return m_sReason;
+        return OUString();
     }
 
     Any SAL_CALL Veto::getDetails()
diff --git a/dbaccess/source/ui/app/AppDetailPageHelper.cxx b/dbaccess/source/ui/app/AppDetailPageHelper.cxx
index 7897e6692227..5262a422fff2 100644
--- a/dbaccess/source/ui/app/AppDetailPageHelper.cxx
+++ b/dbaccess/source/ui/app/AppDetailPageHelper.cxx
@@ -1055,7 +1055,7 @@ void OAppDetailPageHelper::showPreview(const Reference< XContent >& _xContent)
                     Reference<document::XDocumentProperties> xProp(
                         aPreview, UNO_QUERY);
                     if ( xProp.is() )
-                        m_aDocumentInfo->fill(xProp,OUString());
+                        m_aDocumentInfo->fill(xProp);
                 }
             }
             else
diff --git a/dbaccess/source/ui/dlg/CollectionView.cxx b/dbaccess/source/ui/dlg/CollectionView.cxx
index 5b59928037ab..dfc2631f9c1e 100644
--- a/dbaccess/source/ui/dlg/CollectionView.cxx
+++ b/dbaccess/source/ui/dlg/CollectionView.cxx
@@ -73,7 +73,7 @@ OCollectionView::OCollectionView( vcl::Window * pParent
     get(m_pPB_OK, "ok");
 
     OSL_ENSURE(m_xContent.is(),"No valid content!");
-    m_pView->Initialize(m_xContent,OUString());
+    m_pView->Initialize(m_xContent);
     m_pFTCurrentPath->SetStyle( m_pFTCurrentPath->GetStyle() | WB_PATHELLIPSIS );
     initCurrentPath();
 
@@ -132,7 +132,7 @@ IMPL_LINK_NOARG(OCollectionView, Save_Click, Button*, void)
                         xChild.set(m_xContent,UNO_QUERY);
                     }
                 }
-                m_pView->Initialize(m_xContent,OUString());
+                m_pView->Initialize(m_xContent);
                 initCurrentPath();
             }
             sSubFolder = sName.copy(0,nIndex-1);
@@ -201,7 +201,7 @@ IMPL_LINK_NOARG(OCollectionView, NewFolder_Click, Button*, void)
     {
         Reference<XHierarchicalNameContainer> xNameContainer(m_xContent,UNO_QUERY);
         if ( dbaui::insertHierachyElement(this,m_xContext,xNameContainer,OUString(),m_bCreateForm) )
-            m_pView->Initialize(m_xContent,OUString());
+            m_pView->Initialize(m_xContent);
     }
     catch( const SQLException& )
     {
@@ -224,7 +224,7 @@ IMPL_LINK_NOARG(OCollectionView, Up_Click, Button*, void)
             if ( xNameAccess.is() )
             {
                 m_xContent.set(xNameAccess,UNO_QUERY);
-                m_pView->Initialize(m_xContent,OUString());
+                m_pView->Initialize(m_xContent);
                 initCurrentPath();
             }
             else
@@ -255,7 +255,7 @@ IMPL_LINK_NOARG(OCollectionView, Dbl_Click_FileView, SvTreeListBox*, bool)
                 if ( xContent.is() )
                 {
                     m_xContent = xContent;
-                    m_pView->Initialize(m_xContent,OUString());
+                    m_pView->Initialize(m_xContent);
                     initCurrentPath();
                 }
             }
diff --git a/dbaccess/source/ui/inc/TokenWriter.hxx b/dbaccess/source/ui/inc/TokenWriter.hxx
index 120125be6c89..0a8320a9b1d9 100644
--- a/dbaccess/source/ui/inc/TokenWriter.hxx
+++ b/dbaccess/source/ui/inc/TokenWriter.hxx
@@ -126,9 +126,8 @@ namespace dbaui
         // export data
         ORTFImportExport(   const svx::ODataAccessDescriptor& _aDataDescriptor,
                             const css::uno::Reference< css::uno::XComponentContext >& _rM,
-                            const css::uno::Reference< css::util::XNumberFormatter >& _rxNumberF,
-                            const OUString& rExchange = OUString())
-                            : ODatabaseImportExport(_aDataDescriptor,_rM,_rxNumberF,rExchange) {};
+                            const css::uno::Reference< css::util::XNumberFormatter >& _rxNumberF)
+                            : ODatabaseImportExport(_aDataDescriptor,_rM,_rxNumberF,OUString()) {};
 
         // import data
         ORTFImportExport(   const SharedConnection& _rxConnection,
@@ -170,8 +169,7 @@ namespace dbaui
         // export data
         OHTMLImportExport(  const svx::ODataAccessDescriptor& _aDataDescriptor,
                             const css::uno::Reference< css::uno::XComponentContext >& _rM,
-                            const css::uno::Reference< css::util::XNumberFormatter >& _rxNumberF,
-                            const OUString& rExchange = OUString());
+                            const css::uno::Reference< css::util::XNumberFormatter >& _rxNumberF);
         // import data
         OHTMLImportExport(  const SharedConnection& _rxConnection,
                             const css::uno::Reference< css::util::XNumberFormatter >& _rxNumberF,
@@ -206,8 +204,7 @@ namespace dbaui
         ORowSetImportExport(vcl::Window* _pParent,
                             const css::uno::Reference< css::sdbc::XResultSetUpdate >& _xResultSetUpdate,
                             const svx::ODataAccessDescriptor& _aDataDescriptor,
-                            const css::uno::Reference< css::uno::XComponentContext >& _rM,
-                            const OUString& rExchange = OUString());
+                            const css::uno::Reference< css::uno::XComponentContext >& _rM);
 
         virtual bool Write() override;
         virtual bool Read() override;
diff --git a/dbaccess/source/ui/misc/RowSetDrop.cxx b/dbaccess/source/ui/misc/RowSetDrop.cxx
index 944b8b6d631c..e178dea9416c 100644
--- a/dbaccess/source/ui/misc/RowSetDrop.cxx
+++ b/dbaccess/source/ui/misc/RowSetDrop.cxx
@@ -41,10 +41,9 @@ using namespace ::com::sun::star::lang;
 ORowSetImportExport::ORowSetImportExport(   vcl::Window* _pParent,
                                             const Reference< XResultSetUpdate >& _xResultSetUpdate,
                                             const svx::ODataAccessDescriptor& _aDataDescriptor,
-                                            const Reference< XComponentContext >& _rM,
-                                            const OUString& rExchange
+                                            const Reference< XComponentContext >& _rM
                                             )
-                                            : ODatabaseImportExport(_aDataDescriptor,_rM,nullptr,rExchange)
+                                            : ODatabaseImportExport(_aDataDescriptor,_rM,nullptr,OUString())
                                             ,m_xTargetResultSetUpdate(_xResultSetUpdate)
                                             ,m_xTargetRowUpdate(_xResultSetUpdate,UNO_QUERY)
                                             ,m_pParent(_pParent)
diff --git a/dbaccess/source/ui/misc/TokenWriter.cxx b/dbaccess/source/ui/misc/TokenWriter.cxx
index e2edd92abd4e..982d2bad9800 100644
--- a/dbaccess/source/ui/misc/TokenWriter.cxx
+++ b/dbaccess/source/ui/misc/TokenWriter.cxx
@@ -625,9 +625,8 @@ const char OHTMLImportExport::sIndentSource[nIndentMax+1] = "\t\t\t\t\t\t\t\t\t\
 
 OHTMLImportExport::OHTMLImportExport(const svx::ODataAccessDescriptor& _aDataDescriptor,
                                      const Reference< XComponentContext >& _rM,
-                                     const Reference< css::util::XNumberFormatter >& _rxNumberF,
-                                     const OUString& rExchange)
-        : ODatabaseImportExport(_aDataDescriptor,_rM,_rxNumberF,rExchange)
+                                     const Reference< css::util::XNumberFormatter >& _rxNumberF)
+        : ODatabaseImportExport(_aDataDescriptor,_rM,_rxNumberF,OUString())
     ,m_nIndent(0)
 #if OSL_DEBUG_LEVEL > 0
     ,m_bCheckFont(false)
diff --git a/dbaccess/source/ui/querydesign/QTableConnectionData.cxx b/dbaccess/source/ui/querydesign/QTableConnectionData.cxx
index 9fa51f091500..7f5fb4c59ed1 100644
--- a/dbaccess/source/ui/querydesign/QTableConnectionData.cxx
+++ b/dbaccess/source/ui/querydesign/QTableConnectionData.cxx
@@ -47,9 +47,8 @@ OQueryTableConnectionData::OQueryTableConnectionData( const OQueryTableConnectio
 }
 
 OQueryTableConnectionData::OQueryTableConnectionData(const TTableWindowData::value_type& _pReferencingTable,
-                                                     const TTableWindowData::value_type& _pReferencedTable,
-                                                     const OUString& rConnName)
-    : OTableConnectionData( _pReferencingTable,_pReferencedTable, rConnName )
+                                                     const TTableWindowData::value_type& _pReferencedTable)
+    : OTableConnectionData( _pReferencingTable,_pReferencedTable, OUString() )
     , m_nFromEntryIndex(0)
     , m_nDestEntryIndex(0)
     , m_eJoinType (INNER_JOIN)
diff --git a/dbaccess/source/ui/querydesign/QTableConnectionData.hxx b/dbaccess/source/ui/querydesign/QTableConnectionData.hxx
index 6d590cfccbb4..c7137eb5e81b 100644
--- a/dbaccess/source/ui/querydesign/QTableConnectionData.hxx
+++ b/dbaccess/source/ui/querydesign/QTableConnectionData.hxx
@@ -43,8 +43,7 @@ namespace dbaui
     public:
         OQueryTableConnectionData();
         OQueryTableConnectionData( const OQueryTableConnectionData& rConnData );
-        OQueryTableConnectionData( const TTableWindowData::value_type& _pReferencingTable,const TTableWindowData::value_type& _pReferencedTable,
-            const OUString& rConnName=OUString());
+        OQueryTableConnectionData( const TTableWindowData::value_type& _pReferencingTable,const TTableWindowData::value_type& _pReferencedTable );
         virtual ~OQueryTableConnectionData() override;
 
         virtual void CopyFrom(const OTableConnectionData& rSource) override;