diff options
| author | Noel Grandin <noel@peralex.com> | 2016-05-05 09:46:12 +0200 |
|---|---|---|
| committer | Noel Grandin <noelgrandin@gmail.com> | 2016-05-06 06:48:38 +0000 |
| commit | f3d9aab8410c00298f29ca0194c5d33d53c63ff2 (patch) | |
| tree | 370d24d49547d8eb2cdbcb293992d9b9a4a670ed /cui/source/dialogs | |
| parent | 654c98064d3fd2bd1e13ae2bda5f84e8d51d0071 (diff) | |
teach passstuffbyref plugin to check for..
unnecessarily passing primitives by const ref.
Suggested by Tor Lillqvist
Change-Id: I445e220542969ca3e252581e5953fb01cb2b2be6
Reviewed-on: https://gerrit.libreoffice.org/24672
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'cui/source/dialogs')
| -rw-r--r-- | cui/source/dialogs/colorpicker.cxx | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/cui/source/dialogs/colorpicker.cxx b/cui/source/dialogs/colorpicker.cxx index e991a13a8e25..7ba386e1c876 100644 --- a/cui/source/dialogs/colorpicker.cxx +++ b/cui/source/dialogs/colorpicker.cxx @@ -134,7 +134,7 @@ static void RGBtoCMYK( double dR, double dG, double dB, double& fCyan, double& f class HexColorControl : public Edit { public: - HexColorControl( vcl::Window* pParent, const WinBits& nStyle ); + HexColorControl( vcl::Window* pParent, WinBits nStyle ); virtual bool PreNotify( NotifyEvent& rNEvt ) override; virtual void Paste() override; @@ -146,7 +146,7 @@ private: static bool ImplProcessKeyInput( const KeyEvent& rKEv ); }; -HexColorControl::HexColorControl( vcl::Window* pParent, const WinBits& nStyle ) +HexColorControl::HexColorControl( vcl::Window* pParent, WinBits nStyle ) : Edit(pParent, nStyle) { SetMaxTextLen( 6 ); @@ -256,7 +256,7 @@ bool HexColorControl::ImplProcessKeyInput( const KeyEvent& rKEv ) class ColorPreviewControl : public Control { public: - ColorPreviewControl( vcl::Window* pParent, const WinBits& nStyle ); + ColorPreviewControl( vcl::Window* pParent, WinBits nStyle ); virtual void Paint(vcl::RenderContext& rRenderContext, const Rectangle& rRect) override; @@ -266,7 +266,7 @@ private: Color maColor; }; -ColorPreviewControl::ColorPreviewControl(vcl::Window* pParent, const WinBits& nStyle) +ColorPreviewControl::ColorPreviewControl(vcl::Window* pParent, WinBits nStyle) : Control(pParent, nStyle) { } @@ -304,7 +304,7 @@ const ColorMode DefaultMode = HUE; class ColorFieldControl : public Control { public: - ColorFieldControl(vcl::Window* pParent, const WinBits& nStyle); + ColorFieldControl(vcl::Window* pParent, WinBits nStyle); virtual ~ColorFieldControl(); virtual void dispose() override; @@ -346,7 +346,7 @@ private: std::vector<sal_uInt16> maPercent_Vert; }; -ColorFieldControl::ColorFieldControl( vcl::Window* pParent, const WinBits& nStyle ) +ColorFieldControl::ColorFieldControl( vcl::Window* pParent, WinBits nStyle ) : Control( pParent, nStyle ) , meMode( DefaultMode ) , mdX( -1.0 ) @@ -715,7 +715,7 @@ void ColorFieldControl::UpdatePosition() class ColorSliderControl : public Control { public: - ColorSliderControl( vcl::Window* pParent, const WinBits& nStyle ); + ColorSliderControl( vcl::Window* pParent, WinBits nStyle ); virtual ~ColorSliderControl(); virtual void dispose() override; @@ -748,7 +748,7 @@ private: double mdValue; }; -ColorSliderControl::ColorSliderControl( vcl::Window* pParent, const WinBits& nStyle ) +ColorSliderControl::ColorSliderControl( vcl::Window* pParent, WinBits nStyle ) : Control( pParent, nStyle ) , meMode( DefaultMode ) , mpBitmap( nullptr ) |