summaryrefslogtreecommitdiff
path: root/cui/source/dialogs/FontFeaturesDialog.cxx
diff options
context:
space:
mode:
authorNoel Grandin <noel.grandin@collabora.co.uk>2018-07-28 11:28:52 +0200
committerNoel Grandin <noel.grandin@collabora.co.uk>2018-07-28 17:22:52 +0200
commitd407304544cdb2edc3cbdb4e56d49f3ceda79c38 (patch)
tree765668628540687b669d67b14d824adb893c1308 /cui/source/dialogs/FontFeaturesDialog.cxx
parentfa87224130a4ab6c4b79f993cc990adc4be0465b (diff)
loplugin:stringloop cui,dbaccess
Change-Id: I32b63d2435d36b869823ea022ebd7f8347a46ea0 Reviewed-on: https://gerrit.libreoffice.org/58211 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'cui/source/dialogs/FontFeaturesDialog.cxx')
-rw-r--r--cui/source/dialogs/FontFeaturesDialog.cxx16
1 files changed, 8 insertions, 8 deletions
diff --git a/cui/source/dialogs/FontFeaturesDialog.cxx b/cui/source/dialogs/FontFeaturesDialog.cxx
index 676f216e25ec..21c71ce753b7 100644
--- a/cui/source/dialogs/FontFeaturesDialog.cxx
+++ b/cui/source/dialogs/FontFeaturesDialog.cxx
@@ -177,7 +177,7 @@ IMPL_LINK_NOARG(FontFeaturesDialog, ComboBoxSelectedHdl, ComboBox&, void) { upda
OUString FontFeaturesDialog::createFontNameWithFeatures()
{
OUString sResultFontName;
- OUString sNameSuffix;
+ OUStringBuffer sNameSuffix;
bool bFirst = true;
for (FontFeatureItem& rItem : m_aFeatureItems)
@@ -187,11 +187,11 @@ OUString FontFeaturesDialog::createFontNameWithFeatures()
if (rItem.m_pCheck->IsChecked())
{
if (!bFirst)
- sNameSuffix += OUString(vcl::font::FeatureSeparator);
+ sNameSuffix.append(OUString(vcl::font::FeatureSeparator));
else
bFirst = false;
- sNameSuffix += vcl::font::featureCodeAsString(rItem.m_aFeatureCode);
+ sNameSuffix.append(vcl::font::featureCodeAsString(rItem.m_aFeatureCode));
}
}
else if (rItem.m_pCombo && rItem.m_pText)
@@ -200,19 +200,19 @@ OUString FontFeaturesDialog::createFontNameWithFeatures()
if (nSelection > 0)
{
if (!bFirst)
- sNameSuffix += OUString(vcl::font::FeatureSeparator);
+ sNameSuffix.append(OUString(vcl::font::FeatureSeparator));
else
bFirst = false;
- sNameSuffix += vcl::font::featureCodeAsString(rItem.m_aFeatureCode);
- sNameSuffix += "=";
- sNameSuffix += OUString::number(nSelection);
+ sNameSuffix.append(vcl::font::featureCodeAsString(rItem.m_aFeatureCode));
+ sNameSuffix.append("=");
+ sNameSuffix.append(OUString::number(nSelection));
}
}
}
sResultFontName = vcl::font::trimFontNameFeatures(m_sFontName);
if (!sNameSuffix.isEmpty())
- sResultFontName += OUString(vcl::font::FeaturePrefix) + sNameSuffix;
+ sResultFontName += OUString(vcl::font::FeaturePrefix) + sNameSuffix.makeStringAndClear();
return sResultFontName;
}