summaryrefslogtreecommitdiff
path: root/cui/inc
diff options
context:
space:
mode:
authorStephan Bergmann <sbergman@redhat.com>2019-05-24 16:11:45 +0200
committerStephan Bergmann <sbergman@redhat.com>2019-05-24 17:14:02 +0200
commit3e2f1767db05b1bcc17a5f47ae025faee214f6f6 (patch)
treef1f4d74560161ef0d33096b2a3fd7ba770090e5a /cui/inc
parent78e003e0dcfe67cf56618a2af033abe37adee1ca (diff)
Wrong downcast from svx::a11y::AccFrameSelectorChild
...to svx::a11y::AccFrameSelector (which are unrelated final classes). UBSan Calc "Format - Cells... - Borders - Line Arrangement - User-defined:" and clicking into the top-right corner of the widget caused > svx/source/dialog/frmsel.cxx:972:50: runtime error: downcast of address 0x60f0003dfa80 which does not point to an object of type 'a11y::AccFrameSelector' > 0x60f0003dfa80: note: object is of type 'svx::a11y::AccFrameSelectorChild' > e1 03 80 0d 90 4f c2 88 ce 7f 00 00 02 00 00 00 be be be be 00 00 00 00 00 00 00 00 00 00 00 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'svx::a11y::AccFrameSelectorChild' > #0 in svx::FrameSelector::SelectBorder(svx::FrameBorderType) at svx/source/dialog/frmsel.cxx:972:50 > #1 in svx::FrameSelector::MouseButtonDown(MouseEvent const&) at svx/source/dialog/frmsel.cxx:1114:21 [...] The code was like that ever since 60f11adb950e4f9645cc9ecb0f5af8235cc97366 "Integrate branch of IAccessible2", which had presumably confused AccFrameSelector and AccFrameSelectorChild here (while there'd apparently not been a deeper need for the static_casts anyway). Change-Id: I1f52629143dcfc84e57e9539a428fb0f51fdc72e Reviewed-on: https://gerrit.libreoffice.org/72910 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'cui/inc')
0 files changed, 0 insertions, 0 deletions