pvs-studio: V794 The assignment operator should be protected

Change-Id: Ia443a0e61a091d877c8da26bf7d45bf4261f8669
Reviewed-on: https://gerrit.libreoffice.org/62166
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

1 files changed, 12 insertions, 6 deletions

diff --git a/cppuhelper/source/unourl.cxx b/cppuhelper/source/unourl.cxx
index 22250e5568eb..f131a81f68a6 100644
--- a/cppuhelper/source/unourl.cxx
+++ b/cppuhelper/source/unourl.cxx
@@ -140,9 +140,12 @@ UnoUrlDescriptor::~UnoUrlDescriptor()
 
 UnoUrlDescriptor & UnoUrlDescriptor::operator =(UnoUrlDescriptor const & rOther)
 {
-    std::unique_ptr<Impl> newImpl(rOther.m_pImpl->clone());
-    delete m_pImpl;
-    m_pImpl = newImpl.release();
+    if (this != &rOther)
+    {
+        std::unique_ptr<Impl> newImpl(rOther.m_pImpl->clone());
+        delete m_pImpl;
+        m_pImpl = newImpl.release();
+    }
     return *this;
 }
 
@@ -237,9 +240,12 @@ UnoUrl::~UnoUrl()
 
 UnoUrl & UnoUrl::operator =(UnoUrl const & rOther)
 {
-    std::unique_ptr<Impl> newImpl(rOther.m_pImpl->clone());
-    delete m_pImpl;
-    m_pImpl = newImpl.release();
+    if (this != &rOther)
+    {
+        std::unique_ptr<Impl> newImpl(rOther.m_pImpl->clone());
+        delete m_pImpl;
+        m_pImpl = newImpl.release();
+    }
     return *this;
 }