diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2022-05-17 13:57:08 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2022-05-17 17:36:36 +0200 |
commit | e0559fb4c97208f39fedebdf7e4fcd084a165318 (patch) | |
tree | b41c6186dfe29e327547b7737025c8ce8069d717 /cppu/source/uno | |
parent | 4e2f5e85c9c22e57e01d6fa6f585f91287efc7ef (diff) |
clang-tidy modernize-pass-by-value in cppu
Change-Id: I7f6432b9609d175ff7e21ff2e73991275eea60b2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134473
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'cppu/source/uno')
-rw-r--r-- | cppu/source/uno/IdentityMapping.cxx | 7 | ||||
-rw-r--r-- | cppu/source/uno/lbenv.cxx | 7 | ||||
-rw-r--r-- | cppu/source/uno/lbmap.cxx | 27 |
3 files changed, 22 insertions, 19 deletions
diff --git a/cppu/source/uno/IdentityMapping.cxx b/cppu/source/uno/IdentityMapping.cxx index c6dab40cefe8..32ec32c073d3 100644 --- a/cppu/source/uno/IdentityMapping.cxx +++ b/cppu/source/uno/IdentityMapping.cxx @@ -22,6 +22,7 @@ #include <typelib/typedescription.h> #include <uno/mapping.h> #include <uno/environment.hxx> +#include <utility> #include <osl/interlck.h> @@ -35,7 +36,7 @@ struct IdentityMapping : public uno_Mapping sal_Int32 m_nRef; uno::Environment m_env; - explicit IdentityMapping(uno::Environment const & rEnv); + explicit IdentityMapping(uno::Environment aEnv); }; } @@ -86,9 +87,9 @@ static void s_mapInterface(uno_Mapping * pMapping, } -IdentityMapping::IdentityMapping(uno::Environment const & rEnv) +IdentityMapping::IdentityMapping(uno::Environment aEnv) : m_nRef(0), - m_env(rEnv) + m_env(std::move(aEnv)) { uno_Mapping::acquire = s_acquire; uno_Mapping::release = s_release; diff --git a/cppu/source/uno/lbenv.cxx b/cppu/source/uno/lbenv.cxx index f19d8e725e4f..dd29951a6276 100644 --- a/cppu/source/uno/lbenv.cxx +++ b/cppu/source/uno/lbenv.cxx @@ -42,6 +42,7 @@ #include <string_view> #include <unordered_map> +#include <utility> #include <vector> #include <stdio.h> @@ -78,7 +79,7 @@ struct ObjectEntry sal_Int32 nRef; bool mixedObject; - explicit ObjectEntry( const OUString & rOId_ ); + explicit ObjectEntry( OUString aOId_ ); void append( uno_DefaultEnvironment * pEnv, @@ -147,8 +148,8 @@ struct uno_DefaultEnvironment : public uno_ExtEnvironment }; -ObjectEntry::ObjectEntry( OUString const & rOId_ ) - : oid( rOId_ ), +ObjectEntry::ObjectEntry( OUString aOId_ ) + : oid(std::move( aOId_ )), nRef( 0 ), mixedObject( false ) { diff --git a/cppu/source/uno/lbmap.cxx b/cppu/source/uno/lbmap.cxx index 102ef135ef1a..b056193de7b3 100644 --- a/cppu/source/uno/lbmap.cxx +++ b/cppu/source/uno/lbmap.cxx @@ -27,6 +27,7 @@ #include <mutex> #include <set> #include <unordered_map> +#include <utility> #include <rtl/ustring.hxx> #include <rtl/ustrbuf.hxx> @@ -125,11 +126,11 @@ struct MappingEntry MappingEntry( uno_Mapping * pMapping_, uno_freeMappingFunc freeMapping_, - const OUString & rMappingName_ ) + OUString aMappingName_ ) : nRef( 1 ) , pMapping( pMapping_ ) , freeMapping( freeMapping_ ) - , aMappingName( rMappingName_ ) + , aMappingName(std::move( aMappingName_ )) {} }; @@ -192,9 +193,9 @@ struct uno_Mediate_Mapping : public uno_Mapping OUString aAddPurpose; uno_Mediate_Mapping( - const Environment & rFrom_, const Environment & rTo_, - const Mapping & rFrom2Uno_, const Mapping & rUno2To_, - const OUString & rAddPurpose ); + Environment aFrom_, Environment aTo_, + Mapping aFrom2Uno_, Mapping aUno2To_, + OUString aAddPurpose ); }; } @@ -265,15 +266,15 @@ static void mediate_mapInterface( } uno_Mediate_Mapping::uno_Mediate_Mapping( - const Environment & rFrom_, const Environment & rTo_, - const Mapping & rFrom2Uno_, const Mapping & rUno2To_, - const OUString & rAddPurpose_ ) + Environment aFrom_, Environment aTo_, + Mapping aFrom2Uno_, Mapping aUno2To_, + OUString aAddPurpose_ ) : nRef( 1 ) - , aFrom( rFrom_ ) - , aTo( rTo_ ) - , aFrom2Uno( rFrom2Uno_ ) - , aUno2To( rUno2To_ ) - , aAddPurpose( rAddPurpose_ ) + , aFrom(std::move( aFrom_ )) + , aTo(std::move( aTo_ )) + , aFrom2Uno(std::move( aFrom2Uno_ )) + , aUno2To(std::move( aUno2To_ )) + , aAddPurpose(std::move( aAddPurpose_ )) { uno_Mapping::acquire = mediate_acquire; uno_Mapping::release = mediate_release; |