diff options
| author | Julien Nabet <serval2412@yahoo.fr> | 2013-12-13 23:53:29 +0100 |
|---|---|---|
| committer | Julien Nabet <serval2412@yahoo.fr> | 2013-12-14 00:03:22 +0100 |
| commit | ffbde4e6a6ead7efdd65aa6bd31e9ea55f9c637e (patch) | |
| tree | 38387c7f15bc525187fb852c2d3efd150cc1483a /connectivity | |
| parent | 8552bd76dcbb1db407bc9b0c1ab32a9f3afac87a (diff) | |
cppcheck: fix same expression
!pSchemaPat->isEmpty() checked twice where line before we test if aPKQ is empty
so it seemed quite logical to test aPKO here
Change-Id: I79d7ec89f7ae67520492bbd4121a4a86918f2fbf
Diffstat (limited to 'connectivity')
| -rw-r--r-- | connectivity/source/drivers/odbcbase/ODatabaseMetaDataResultSet.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/connectivity/source/drivers/odbcbase/ODatabaseMetaDataResultSet.cxx b/connectivity/source/drivers/odbcbase/ODatabaseMetaDataResultSet.cxx index 2e772fc17f00..f7af806be51a 100644 --- a/connectivity/source/drivers/odbcbase/ODatabaseMetaDataResultSet.cxx +++ b/connectivity/source/drivers/odbcbase/ODatabaseMetaDataResultSet.cxx @@ -999,7 +999,7 @@ void ODatabaseMetaDataResultSet::openColumns( const Any& catalog, aCOL = OUStringToOString(columnNamePattern,m_nTextEncoding); const char *pPKQ = catalog.hasValue() && !aPKQ.isEmpty() ? aPKQ.getStr() : NULL, - *pPKO = pSchemaPat && !pSchemaPat->isEmpty() && !pSchemaPat->isEmpty() ? aPKO.getStr() : NULL, + *pPKO = pSchemaPat && !pSchemaPat->isEmpty() && !aPKO.isEmpty() ? aPKO.getStr() : NULL, *pPKN = aPKN.getStr(), *pCOL = aCOL.getStr(); |